From: David Miller <davem@davemloft.net>
To: marex@denx.de
Cc: netdev@vger.kernel.org, david.choi@micrel.com,
nobuhiro.iwamatsu.yj@renesas.com, fabio.estevam@freescale.com,
shawn.guo@linaro.org
Subject: Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021
Date: Fri, 21 Sep 2012 15:11:04 -0400 (EDT) [thread overview]
Message-ID: <20120921.151104.718226045755546422.davem@davemloft.net> (raw)
In-Reply-To: <201209212106.53069.marex@denx.de>
From: Marek Vasut <marex@denx.de>
Date: Fri, 21 Sep 2012 21:06:52 +0200
> You know, youth and all ... I was under the impression the patches shall be
> checkpatch clean. But you got me there quite well, something must be wrong with
> my precommit hook.
checkpatch is not a panacea, and it is in particular not an automaton
that one uses without using any human judgement at all.
In particular, checkpatch does not enforce the comment style we use in
the networking code nor several other conventions that we use which
are slightly different from the rest of the tree.
Therefore strick checkpatch conformance is never appropriate.
> Anyway, about the checkpatch cleanup of the file, will that be
> welcome (afterwards I fix the patchset and repost)?
See above, strict checkpatch cleanups, especially those done in
a completely automaton style with zero human judgment involved,
are not welcome.
next prev parent reply other threads:[~2012-09-21 19:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:52 [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021 Marek Vasut
2012-09-21 2:52 ` [PATCH 2/3 V2] phy/micrel: Rename KS80xx to KSZ80xx Marek Vasut
2012-09-21 2:52 ` [PATCH 3/3 RESEND] phy/micrel: Add missing header to micrel_phy.h Marek Vasut
2012-09-21 17:42 ` [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021 David Miller
2012-09-21 18:04 ` Marek Vasut
2012-09-21 18:10 ` David Miller
2012-09-21 18:33 ` Marek Vasut
2012-09-21 18:48 ` David Miller
2012-09-21 18:50 ` Marek Vasut
2012-09-21 18:54 ` David Miller
2012-09-21 19:06 ` Marek Vasut
2012-09-21 19:11 ` David Miller [this message]
2012-09-21 19:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921.151104.718226045755546422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.choi@micrel.com \
--cc=fabio.estevam@freescale.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).