* [PATCH] netlink: use <linux/export.h> instead of <linux/module.h>
@ 2012-09-21 19:35 pablo
2012-09-21 19:44 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: pablo @ 2012-09-21 19:35 UTC (permalink / raw)
To: netdev; +Cc: davem
From: Pablo Neira Ayuso <pablo@netfilter.org>
Since (9f00d97 netlink: hide struct module parameter in netlink_kernel_create),
linux/netlink.h includes linux/module.h because of the use of THIS_MODULE.
Use linux/export.h instead, as suggested by Stephen Rothwell, which is
significantly smaller and defines THIS_MODULES.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
include/linux/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 73ade5f..b3dc992 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -153,7 +153,7 @@ struct nlattr {
#include <linux/capability.h>
#include <linux/skbuff.h>
-#include <linux/module.h>
+#include <linux/export.h>
#include <net/scm.h>
struct net;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] netlink: use <linux/export.h> instead of <linux/module.h>
2012-09-21 19:35 [PATCH] netlink: use <linux/export.h> instead of <linux/module.h> pablo
@ 2012-09-21 19:44 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-21 19:44 UTC (permalink / raw)
To: pablo; +Cc: netdev
From: pablo@netfilter.org
Date: Fri, 21 Sep 2012 21:35:38 +0200
> From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> Since (9f00d97 netlink: hide struct module parameter in netlink_kernel_create),
> linux/netlink.h includes linux/module.h because of the use of THIS_MODULE.
>
> Use linux/export.h instead, as suggested by Stephen Rothwell, which is
> significantly smaller and defines THIS_MODULES.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied, but please make explicit what tree you are targetting when you
submit changes like this in the future.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-21 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-21 19:35 [PATCH] netlink: use <linux/export.h> instead of <linux/module.h> pablo
2012-09-21 19:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).