From: Marek Vasut <marex@denx.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, david.choi@micrel.com,
nobuhiro.iwamatsu.yj@renesas.com, fabio.estevam@freescale.com,
shawn.guo@linaro.org
Subject: Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021
Date: Fri, 21 Sep 2012 20:04:09 +0200 [thread overview]
Message-ID: <201209212004.10148.marex@denx.de> (raw)
In-Reply-To: <20120921.134215.1719885507288305623.davem@davemloft.net>
Dear David Miller,
> From: Marek Vasut <marex@denx.de>
> Date: Fri, 21 Sep 2012 04:52:54 +0200
>
> > + phy_write(phydev, MII_KSZPHY_OMSO,
> > + KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE);
>
> This is not indented properly. The goal is not to exclusively use
> TAB characters to indent code until it sort-of looks fine.
The goal was to avoid checkpatch trouble.
> Rather, the goal is to properly line up function arguments with
> the first column after the openning parenthesis on the previous
> line. Using TAB and SPACE characters, as needed.
>
> > + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
> > + | SUPPORTED_Asym_Pause),
>
> This is similarly not styled properly.
This is copy-pasted from other entry. I'd hate to reformat the whole file.
> Besies being indented imporperly on the second line, the final "|"
> character should be at the end of the first line, rather than
> start the second line.
DTTO here.
> Resubmit this entire patch series, not just this one patch, once
> you've made these corrections.
>
> Thanks.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-21 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:52 [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021 Marek Vasut
2012-09-21 2:52 ` [PATCH 2/3 V2] phy/micrel: Rename KS80xx to KSZ80xx Marek Vasut
2012-09-21 2:52 ` [PATCH 3/3 RESEND] phy/micrel: Add missing header to micrel_phy.h Marek Vasut
2012-09-21 17:42 ` [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021 David Miller
2012-09-21 18:04 ` Marek Vasut [this message]
2012-09-21 18:10 ` David Miller
2012-09-21 18:33 ` Marek Vasut
2012-09-21 18:48 ` David Miller
2012-09-21 18:50 ` Marek Vasut
2012-09-21 18:54 ` David Miller
2012-09-21 19:06 ` Marek Vasut
2012-09-21 19:11 ` David Miller
2012-09-21 19:19 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209212004.10148.marex@denx.de \
--to=marex@denx.de \
--cc=davem@davemloft.net \
--cc=david.choi@micrel.com \
--cc=fabio.estevam@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).