From: David Miller <davem@davemloft.net>
To: marex@denx.de
Cc: netdev@vger.kernel.org, david.choi@micrel.com,
nobuhiro.iwamatsu.yj@renesas.com
Subject: Re: [PATCH 1/3 V3] phy/micrel: Implement support for KSZ8021
Date: Sat, 22 Sep 2012 15:31:22 -0400 (EDT) [thread overview]
Message-ID: <20120922.153122.1337768859179326955.davem@davemloft.net> (raw)
In-Reply-To: <1348278110-11603-1-git-send-email-marex@denx.de>
From: Marek Vasut <marex@denx.de>
Date: Sat, 22 Sep 2012 03:41:47 +0200
> + .name = "Micrel KSZ8021",
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause |
> + SUPPORTED_Asym_Pause),
You only fixed one of the two coding style problems I pointed out.
>From my original email:
====================
This is similarly not styled properly.
Besies being indented imporperly on the second line, the final "|"
character should be at the end of the first line, rather than
start the second line.
====================
Note "indented improperly on the second line"
Which is a clear reference to the first piece of
feedback I gave earlier in the same reply:
====================
This is not indented properly. The goal is not to exclusively use
TAB characters to indent code until it sort-of looks fine.
Rather, the goal is to properly line up function arguments with
the first column after the openning parenthesis on the previous
line. Using TAB and SPACE characters, as needed.
====================
next prev parent reply other threads:[~2012-09-22 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 1:41 [PATCH 1/3 V3] phy/micrel: Implement support for KSZ8021 Marek Vasut
2012-09-22 1:41 ` [PATCH 2/3 V3] phy/micrel: Rename KS80xx to KSZ80xx Marek Vasut
2012-09-22 1:41 ` [PATCH 3/3 RESEND] phy/micrel: Add missing header to micrel_phy.h Marek Vasut
2012-09-22 19:31 ` David Miller [this message]
2012-09-24 1:29 ` [PATCH 1/3 V4] phy/micrel: Implement support for KSZ8021 Marek Vasut
2012-09-24 1:45 ` David Miller
2012-09-24 2:56 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922.153122.1337768859179326955.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.choi@micrel.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).