From: David Miller <davem@davemloft.net>
To: peterhuewe@gmx.de
Cc: jacmet@sunsite.dk, david.daney@cavium.com,
chohnstaedt@innominate.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver
Date: Sat, 22 Sep 2012 15:34:26 -0400 (EDT) [thread overview]
Message-ID: <20120922.153426.978507671721485161.davem@davemloft.net> (raw)
In-Reply-To: <1348281858-24366-1-git-send-email-peterhuewe@gmx.de>
From: Peter Huewe <peterhuewe@gmx.de>
Date: Sat, 22 Sep 2012 04:44:18 +0200
> Currently the driver has no MODULE_LICENSE attribute in its source which
> results in a kernel taint if I load this:
>
> root@(none):~# modprobe bcm87xx
> bcm87xx: module license 'unspecified' taints kernel.
>
> Since the first lines of the source code clearly state:
> * This file is subject to the terms and conditions of the GNU General
> * Public License. See the file "COPYING" in the main directory of this
> * archive for more details.
> I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove
> the kernel taint.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Good catch, applied, thanks.
prev parent reply other threads:[~2012-09-22 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 2:44 [PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver Peter Huewe
2012-09-22 19:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922.153426.978507671721485161.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chohnstaedt@innominate.com \
--cc=david.daney@cavium.com \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox