From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: subramanian.vijay@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bhutchings@solarflare.com,
alexander.h.duyck@intel.com
Subject: Re: [PATCH net-next v1] net: use a per task frag allocator
Date: Sat, 22 Sep 2012 15:52:55 -0400 (EDT) [thread overview]
Message-ID: <20120922.155255.396667016733201083.davem@davemloft.net> (raw)
In-Reply-To: <1348261871.2669.962.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Sep 2012 23:11:11 +0200
> On Fri, 2012-09-21 at 13:27 -0700, Vijay Subramanian wrote:
>> I get the following compile error with the newer version of the patch
>>
>> net/sched/em_meta.c: In function ‘meta_int_sk_sendmsg_off’:
>> net/sched/em_meta.c:464: error: ‘struct sock’ has no member named
>> ‘sk_sndmsg_off’
>> make[1]: *** [net/sched/em_meta.o] Error 1
>> make: *** [net/sched/em_meta.o] Error 2
>>
>>
>>
>> Vijay
>
> Oh well, I wonder what's the expected use of this crap...
>
> Thanks, I'll fix this on v3 !
So many aspects of the meta match are an extreme burdon on development
because the keys it allows unnecessarily exposes internals of our
implementation.
Who really uses it? Maybe we can schedule it for removal.
next prev parent reply other threads:[~2012-09-22 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 16:56 [PATCH net-next v1] net: use a per task frag allocator Eric Dumazet
2012-09-20 21:48 ` David Miller
2012-09-21 14:57 ` Eric Dumazet
2012-09-21 20:27 ` Vijay Subramanian
2012-09-21 21:11 ` Eric Dumazet
2012-09-22 19:52 ` David Miller [this message]
2012-09-24 9:04 ` [PATCH net-next v3] " Eric Dumazet
2012-09-24 18:34 ` Vijay Subramanian
2012-09-24 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922.155255.396667016733201083.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).