From: David Miller <davem@davemloft.net>
To: vipul@chelsio.com
Cc: netdev@vger.kernel.org
Subject: You have to fix this
Date: Thu, 27 Sep 2012 18:34:06 -0400 (EDT) [thread overview]
Message-ID: <20120927.183406.962014014858457666.davem@davemloft.net> (raw)
You cannot put such monster sized local data objects on the stack:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c: In function ‘t4_memory_rw.constprop.6’:
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:484:1: warning: the frame size of 2056 bytes is larger than 2048 bytes [-Wframe-larger-than=]
That's because of this thing:
__be32 data[MEMWIN0_APERTURE/sizeof(__be32)];
I'm really surprised this didn't show up in any of your test builds.
Or are you ignoring warnings that your changes add?
next reply other threads:[~2012-09-27 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 22:34 David Miller [this message]
2012-09-28 11:59 ` You have to fix this Vipul Pandya
2012-09-28 17:43 ` David Miller
2012-10-03 10:12 ` Vipul Pandya
2012-10-03 21:17 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927.183406.962014014858457666.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vipul@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).