From: David Miller <davem@davemloft.net>
To: Sathya.Perla@Emulex.Com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 4/5] be2net: get rid of AMAP_SET/GET macros in TX path
Date: Fri, 28 Sep 2012 03:10:27 -0400 (EDT) [thread overview]
Message-ID: <20120928.031027.963540575540777486.davem@davemloft.net> (raw)
In-Reply-To: <CF9D1877D81D214CB0CA0669EFAE020C65638C@CMEXMB1.ad.emulex.com>
From: "Perla, Sathya" <Sathya.Perla@Emulex.Com>
Date: Fri, 28 Sep 2012 07:05:27 +0000
>>-----Original Message-----
>>From: David Miller [mailto:davem@davemloft.net]
>>
>>> endianness is handled even in this patch. The call to wrb_fill_hdr()
>>> is followed by be_dws_cpu_to_le() to handle this.
>>
>>That swap_dws() thing is the most inefficient thing I've ever seen.
>>
>>Instead of being able to benefit from compile time optimizations
>>such as byte swaps of constants, you do everything hidden from the
>>compiler so nothing gets optimized.
>
> I'd like to clarify that swap_dws() was being used/needed even in
> the old code.
I fully understand this.
next prev parent reply other threads:[~2012-09-28 7:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348727568-2011-1-git-send-email-sathya.perla@emulex.com>
2012-09-27 6:32 ` [net-next PATCH 1/5] be2net: remove type argument of be_cmd_mac_addr_query() Sathya Perla
2012-09-27 6:32 ` [net-next PATCH 2/5] be2net: fix wrong handling of be_setup() failure in be_probe() Sathya Perla
2012-09-27 6:32 ` [net-next PATCH 3/5] be2net: cleanup code related to be_link_status_query() Sathya Perla
2012-09-27 6:32 ` [net-next PATCH 4/5] be2net: get rid of AMAP_SET/GET macros in TX path Sathya Perla
2012-09-28 2:29 ` David Miller
2012-09-28 5:47 ` Perla, Sathya
2012-09-28 6:40 ` David Miller
2012-09-28 7:05 ` Perla, Sathya
2012-09-28 7:10 ` David Miller [this message]
2012-09-27 6:32 ` [net-next PATCH 5/5] be2net: fixup log messages Sathya Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928.031027.963540575540777486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Sathya.Perla@Emulex.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).