* drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
@ 2012-09-28 13:06 Fengguang Wu
2012-10-03 10:46 ` Jesper Nilsson
0 siblings, 1 reply; 6+ messages in thread
From: Fengguang Wu @ 2012-09-28 13:06 UTC (permalink / raw)
To: Jesper Nilsson; +Cc: kernel-janitors, netdev
Hi Jesper,
FYI, a rather old build bug that's introduced by
bafef0a cris build fixes: update eth_v10.c ethernet driver
All error/warnings:
drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
drivers/net/cris/eth_v10.c:1131:1: note: declared here
vim +1715 drivers/net/cris/eth_v10.c
^1da177e (Linus Torvalds 2005-04-16 1710)
bafef0ae (Jesper Nilsson 2007-11-14 1711) #ifdef CONFIG_NET_POLL_CONTROLLER
bafef0ae (Jesper Nilsson 2007-11-14 1712) static void
bafef0ae (Jesper Nilsson 2007-11-14 1713) e100_netpoll(struct net_device* netdev)
bafef0ae (Jesper Nilsson 2007-11-14 1714) {
bafef0ae (Jesper Nilsson 2007-11-14 @1715) e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
bafef0ae (Jesper Nilsson 2007-11-14 1716) }
bafef0ae (Jesper Nilsson 2007-11-14 1717) #endif
bafef0ae (Jesper Nilsson 2007-11-14 1718)
^1da177e (Linus Torvalds 2005-04-16 1719) static int
^1da177e (Linus Torvalds 2005-04-16 1720) etrax_init_module(void)
^1da177e (Linus Torvalds 2005-04-16 1721) {
^1da177e (Linus Torvalds 2005-04-16 1722) return etrax_ethernet_init();
^1da177e (Linus Torvalds 2005-04-16 1723) }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' 2012-09-28 13:06 drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' Fengguang Wu @ 2012-10-03 10:46 ` Jesper Nilsson 2012-10-03 18:40 ` David Miller 0 siblings, 1 reply; 6+ messages in thread From: Jesper Nilsson @ 2012-10-03 10:46 UTC (permalink / raw) To: Fengguang Wu; +Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote: > Hi Jesper, Hi! > FYI, a rather old build bug that's introduced by > > bafef0a cris build fixes: update eth_v10.c ethernet driver > > All error/warnings: > > drivers/net/cris/eth_v10.c: In function 'e100_netpoll': > drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' > drivers/net/cris/eth_v10.c:1131:1: note: declared here Yep, I can't figure out why the followup patches never reached mainline, but we have fixes for exactly that in our in-house tree. I'll push some move patches after this merge window. > vim +1715 drivers/net/cris/eth_v10.c > > ^1da177e (Linus Torvalds 2005-04-16 1710) > bafef0ae (Jesper Nilsson 2007-11-14 1711) #ifdef CONFIG_NET_POLL_CONTROLLER > bafef0ae (Jesper Nilsson 2007-11-14 1712) static void > bafef0ae (Jesper Nilsson 2007-11-14 1713) e100_netpoll(struct net_device* netdev) > bafef0ae (Jesper Nilsson 2007-11-14 1714) { > bafef0ae (Jesper Nilsson 2007-11-14 @1715) e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL); > bafef0ae (Jesper Nilsson 2007-11-14 1716) } > bafef0ae (Jesper Nilsson 2007-11-14 1717) #endif > bafef0ae (Jesper Nilsson 2007-11-14 1718) > ^1da177e (Linus Torvalds 2005-04-16 1719) static int > ^1da177e (Linus Torvalds 2005-04-16 1720) etrax_init_module(void) > ^1da177e (Linus Torvalds 2005-04-16 1721) { > ^1da177e (Linus Torvalds 2005-04-16 1722) return etrax_ethernet_init(); > ^1da177e (Linus Torvalds 2005-04-16 1723) } Thanks! /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' 2012-10-03 10:46 ` Jesper Nilsson @ 2012-10-03 18:40 ` David Miller 2012-10-03 20:26 ` Jesper Nilsson 0 siblings, 1 reply; 6+ messages in thread From: David Miller @ 2012-10-03 18:40 UTC (permalink / raw) To: jesper.nilsson; +Cc: fengguang.wu, kernel-janitors, netdev From: Jesper Nilsson <jesper.nilsson@axis.com> Date: Wed, 3 Oct 2012 12:46:52 +0200 > On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote: >> Hi Jesper, > > Hi! > >> FYI, a rather old build bug that's introduced by >> >> bafef0a cris build fixes: update eth_v10.c ethernet driver >> >> All error/warnings: >> >> drivers/net/cris/eth_v10.c: In function 'e100_netpoll': >> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' >> drivers/net/cris/eth_v10.c:1131:1: note: declared here > > Yep, I can't figure out why the followup patches never reached mainline, > but we have fixes for exactly that in our in-house tree. > I'll push some move patches after this merge window. It's a bug fix, even worse a build fix, why want until after the merge window? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' 2012-10-03 18:40 ` David Miller @ 2012-10-03 20:26 ` Jesper Nilsson 2012-10-05 21:24 ` Jesper Nilsson 0 siblings, 1 reply; 6+ messages in thread From: Jesper Nilsson @ 2012-10-03 20:26 UTC (permalink / raw) To: David Miller Cc: fengguang.wu@intel.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org On Wed, Oct 03, 2012 at 08:40:40PM +0200, David Miller wrote: > From: Jesper Nilsson <jesper.nilsson@axis.com> > Date: Wed, 3 Oct 2012 12:46:52 +0200 > > > On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote: > >> Hi Jesper, > > > > Hi! > > > >> FYI, a rather old build bug that's introduced by > >> > >> bafef0a cris build fixes: update eth_v10.c ethernet driver > >> > >> All error/warnings: > >> > >> drivers/net/cris/eth_v10.c: In function 'e100_netpoll': > >> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' > >> drivers/net/cris/eth_v10.c:1131:1: note: declared here > > > > Yep, I can't figure out why the followup patches never reached mainline, > > but we have fixes for exactly that in our in-house tree. > > I'll push some move patches after this merge window. > > It's a bug fix, even worse a build fix, why want until after the merge > window? Aye, true, I'll just have to make sure I don't get any other change from the inhouse tree. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' 2012-10-03 20:26 ` Jesper Nilsson @ 2012-10-05 21:24 ` Jesper Nilsson 2012-10-06 1:07 ` Fengguang Wu 0 siblings, 1 reply; 6+ messages in thread From: Jesper Nilsson @ 2012-10-05 21:24 UTC (permalink / raw) To: David Miller Cc: fengguang.wu@intel.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org On Wed, Oct 03, 2012 at 10:26:57PM +0200, Jesper Nilsson wrote: > On Wed, Oct 03, 2012 at 08:40:40PM +0200, David Miller wrote: > > From: Jesper Nilsson <jesper.nilsson@axis.com> > > Date: Wed, 3 Oct 2012 12:46:52 +0200 > > > > > On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote: > > >> Hi Jesper, > > > > > > Hi! > > > > > >> FYI, a rather old build bug that's introduced by > > >> > > >> bafef0a cris build fixes: update eth_v10.c ethernet driver > > >> > > >> All error/warnings: > > >> > > >> drivers/net/cris/eth_v10.c: In function 'e100_netpoll': > > >> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' > > >> drivers/net/cris/eth_v10.c:1131:1: note: declared here > > > > > > Yep, I can't figure out why the followup patches never reached mainline, > > > but we have fixes for exactly that in our in-house tree. > > > I'll push some move patches after this merge window. > > > > It's a bug fix, even worse a build fix, why want until after the merge > > window? > > Aye, true, I'll just have to make sure I don't get any other change from > the inhouse tree. Turns out this was already fixed in mainline since August. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' 2012-10-05 21:24 ` Jesper Nilsson @ 2012-10-06 1:07 ` Fengguang Wu 0 siblings, 0 replies; 6+ messages in thread From: Fengguang Wu @ 2012-10-06 1:07 UTC (permalink / raw) To: Jesper Nilsson Cc: David Miller, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org On Fri, Oct 05, 2012 at 11:24:22PM +0200, Jesper Nilsson wrote: > On Wed, Oct 03, 2012 at 10:26:57PM +0200, Jesper Nilsson wrote: > > On Wed, Oct 03, 2012 at 08:40:40PM +0200, David Miller wrote: > > > From: Jesper Nilsson <jesper.nilsson@axis.com> > > > Date: Wed, 3 Oct 2012 12:46:52 +0200 > > > > > > > On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote: > > > >> Hi Jesper, > > > > > > > > Hi! > > > > > > > >> FYI, a rather old build bug that's introduced by > > > >> > > > >> bafef0a cris build fixes: update eth_v10.c ethernet driver > > > >> > > > >> All error/warnings: > > > >> > > > >> drivers/net/cris/eth_v10.c: In function 'e100_netpoll': > > > >> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' > > > >> drivers/net/cris/eth_v10.c:1131:1: note: declared here > > > > > > > > Yep, I can't figure out why the followup patches never reached mainline, > > > > but we have fixes for exactly that in our in-house tree. > > > > I'll push some move patches after this merge window. > > > > > > It's a bug fix, even worse a build fix, why want until after the merge > > > window? > > > > Aye, true, I'll just have to make sure I don't get any other change from > > the inhouse tree. > > Turns out this was already fixed in mainline since August. Embarrassing.. It must be testing some git tree that's based on one upstream HEAD sometime between where the bug was introduced and where it's fixed. Thanks, Fengguang ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-06 1:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-28 13:06 drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' Fengguang Wu 2012-10-03 10:46 ` Jesper Nilsson 2012-10-03 18:40 ` David Miller 2012-10-03 20:26 ` Jesper Nilsson 2012-10-05 21:24 ` Jesper Nilsson 2012-10-06 1:07 ` Fengguang Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).