From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ramesh Nagappa <ramesh.nagappa@ericsson.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"michel@digirati.com.br" <michel@digirati.com.br>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>
Subject: Re: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic
Date: Fri, 28 Sep 2012 16:52:09 -0700 [thread overview]
Message-ID: <20120928235209.GA11474@kroah.com> (raw)
In-Reply-To: <CA3E5132752D1F49871ED0FC40D56BBA43ECE2E72D@EUSAACMS0701.eamcs.ericsson.se>
On Fri, Sep 28, 2012 at 07:40:39PM -0400, Ramesh Nagappa wrote:
> >From fd023edd911ef12aca38a72b40241661c202684f Mon Sep 17 00:00:00 2001
> From: Ramesh Nagappa <ramesh.nagappa@ericsson.com>
> Date: Thu, 27 Sep 2012 10:20:58 -0700
> Subject: [PATCH] net: fix neigh_resolve_output can cause skb_under_panic
Why is all of this in the middle of the changelog section?
I'm guessing you didn't use 'git send-email' for this?
And why are you copying me on the patch?
> The retry loop in the neigh_resolve_output() and neigh_connected_output() can add
> a hard_header without resetting the skb to network header. This causes the
> skb_push() in dev_hard_header() to fail.
> Signed-off-by: Ramesh Nagappa <ramesh.nagappa@ericsson.com>
> Signed-off-by: Shawn Lu <shawn.lu@ericsson.com>
> Reviewed-by: Billie Alsup <billie.alsup@ericsson.com>
> Reviewed-by: Robert Coulson <robert.coulson@ericsson.com>
You need a blank line before the first Signed-off-by: line. Surely one
of the reviewers should have caught this basic thing?
greg k-h
next prev parent reply other threads:[~2012-09-28 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 23:40 [PATCH] net: fix neigh_resolve_output can cause skb_under_panic Ramesh Nagappa
2012-09-28 23:52 ` gregkh [this message]
2012-09-29 0:17 ` Ramesh Nagappa
2012-09-29 0:26 ` Ramesh Nagappa
2012-09-29 0:57 ` gregkh
2012-10-01 18:00 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928235209.GA11474@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@digirati.com.br \
--cc=netdev@vger.kernel.org \
--cc=ramesh.nagappa@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).