From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH 3/4] be2net: cleanup code related to be_link_status_query()
Date: Sun, 30 Sep 2012 02:16:16 -0400 (EDT) [thread overview]
Message-ID: <20120930.021616.2300886737245762860.davem@davemloft.net> (raw)
In-Reply-To: <851da7da-1e96-4aed-97f1-1207d73f9cf6@CMEXHTCAS2.ad.emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Fri, 28 Sep 2012 20:09:43 +0530
> 1) link_status_query() is always called to query the link-speed (speed
> after applying qos). When there is no qos setting, link-speed is derived from
> port-speed. Do all this inside this routine and hide this from the callers.
>
> 2) adpater->phy.forced_port_speed is not being set anywhere after being
> initialized. Get rid of this variable.
>
> 3) Ignore async link_speed notifications till the initial value has been
> fetched from FW.
>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied.
next prev parent reply other threads:[~2012-09-30 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348843184-22214-1-git-send-email-sathya.perla@emulex.com>
2012-09-28 14:39 ` [net-next PATCH 1/4] be2net: remove type argument of be_cmd_mac_addr_query() Sathya Perla
2012-09-30 6:15 ` David Miller
2012-09-28 14:39 ` [net-next PATCH 2/4] be2net: fix wrong handling of be_setup() failure in be_probe() Sathya Perla
2012-09-30 6:15 ` David Miller
2012-09-28 14:39 ` [net-next PATCH 3/4] be2net: cleanup code related to be_link_status_query() Sathya Perla
2012-09-30 6:16 ` David Miller [this message]
2012-09-28 14:39 ` [net-next PATCH 4/4] be2net: fixup log messages Sathya Perla
2012-09-28 15:39 ` Joe Perches
2012-09-30 6:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120930.021616.2300886737245762860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).