From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [patch] net/key/af_key.c: add range checks on
 ->sadb_x_policy_len
Date: Mon, 01 Oct 2012 17:15:31 -0400 (EDT)
Message-ID: <20121001.171531.1225138780751285845.davem@davemloft.net>
References: <20120928082119.GA32008@elgon.mountain>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: ebiederm@xmission.com, eric.dumazet@gmail.com,
	shemminger@vyatta.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
To: dan.carpenter@oracle.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:41220 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752612Ab2JAVPd (ORCPT
	<rfc822;netdev@vger.kernel.org>); Mon, 1 Oct 2012 17:15:33 -0400
In-Reply-To: <20120928082119.GA32008@elgon.mountain>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Sep 2012 11:21:19 +0300

> Because sizeof() is size_t then if "len" is negative, it counts as a
> large positive value.
> 
> The call tree looks like:
> pfkey_sendmsg()
> -> pfkey_process()
>    -> pfkey_spdadd()
>       -> parse_ipsecrequests()
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This is a static checker fix.  I'm not very familiar with this code.
> I think if we were to hit this then we would try to parse invalid data
> and it would return -EINVAL or similar error code pretty quickly.

Applied and queued up for -stable, thanks Dan.