From: David Miller <davem@davemloft.net>
To: matthew@walster.org
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: ethernet: clean out braces / old code (found via checkpatch)
Date: Tue, 02 Oct 2012 14:46:03 -0400 (EDT) [thread overview]
Message-ID: <20121002.144603.513292881191877964.davem@davemloft.net> (raw)
In-Reply-To: <1349178105-28269-2-git-send-email-matthew@walster.org>
From: matthew@walster.org
Date: Tue, 2 Oct 2012 12:41:44 +0100
> From: Matthew Walster <matthew@walster.org>
>
> Remove an old commented out piece of code.
> Remove an if(true) statement.
> Remove a set of braces that weren't strictly necessary.
>
> All found by running checkpatch.pl against the code.
>
> Signed-off-by: Matthew Walster <matthew@walster.org>
That comment and that unconditional if() are documentation.
Don't be an automaton and blindly make changes based upon
checkpatch.pl output.
next prev parent reply other threads:[~2012-10-02 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 11:41 checkpatch run on net/ethernet matthew
2012-10-02 11:41 ` [PATCH 1/2] net: ethernet: clean out braces / old code (found via checkpatch) matthew
2012-10-02 18:46 ` David Miller [this message]
2012-10-02 11:41 ` [PATCH 2/2] net: ethernet: Remove obsolete comment matthew
2012-10-02 18:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002.144603.513292881191877964.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@walster.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).