From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org, fengguang.wu@intel.com
Subject: Re: [PATCH] tg3: Fix sparse warnings.
Date: Tue, 02 Oct 2012 23:22:09 -0400 (EDT) [thread overview]
Message-ID: <20121002.232209.521171138659193934.davem@davemloft.net> (raw)
In-Reply-To: <1349235074-18927-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Tue, 2 Oct 2012 20:31:14 -0700
> drivers/net/ethernet/broadcom/tg3.c:8121:8: warning: symbol 'i' shadows an earlier one
> drivers/net/ethernet/broadcom/tg3.c:8003:6: originally declared here
> drivers/net/ethernet/broadcom/tg3.c:785:5: warning: symbol 'tg3_ape_scratchpad_read' was not declared. Should it be static?
> drivers/net/ethernet/broadcom/tg3.c:7781:19: warning: Using plain integer as NULL pointer
> drivers/net/ethernet/broadcom/tg3.c:10231:31: error: bad constant expression
>
> Reported-by: Fengguang Wu <fenguang.wu@intel.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
prev parent reply other threads:[~2012-10-03 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 3:31 [PATCH] tg3: Fix sparse warnings Michael Chan
2012-10-03 3:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002.232209.521171138659193934.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).