From: David Miller <davem@davemloft.net>
To: nikolay@redhat.com
Cc: sony.chacko@qlogic.com, agospoda@redhat.com,
rajesh.borundia@qlogic.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] netxen: write IP address to firmware when using bonding
Date: Wed, 03 Oct 2012 14:38:55 -0400 (EDT) [thread overview]
Message-ID: <20121003.143855.520640065174429479.davem@davemloft.net> (raw)
In-Reply-To: <506C0346.8010708@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Wed, 03 Oct 2012 11:20:06 +0200
> I just synced with upstream, I've missed a few patches and it seems
> that it doesn't apply cleanly because my previous patch was
> changed before it was applied. There is one character missing from
> a comment - "/* root bus? */", in upstream it was changed to
> /* root bus */.
> ("netxen: check for root bus in netxen_mask_aer_correctable")
>
> About the rest, after QLogic test the functionality I'll clean-up the
> empty lines and re-send it.
Can you please not quote an entire patch just to make a small series
of comments?
Just quote the exact relevant portions of the patch if you want to
specifically make comments about something.
Quoting the entire patch is extremely bad netiquette, wastes
bandwidth, and everyone on the list has to receive a whole new copy of
the entire patch again for no good reason.
next prev parent reply other threads:[~2012-10-03 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:48 [PATCH net-next] netxen: write IP address to firmware when using bonding Nikolay Aleksandrov
2012-09-25 15:59 ` Rajesh Borundia
2012-09-25 16:43 ` Nikolay Aleksandrov
2012-09-25 18:28 ` Rajesh Borundia
2012-10-02 9:16 ` [PATCH net-next v2] " Nikolay Aleksandrov
2012-10-03 2:40 ` David Miller
2012-10-03 9:20 ` Nikolay Aleksandrov
2012-10-03 18:38 ` David Miller [this message]
2012-10-08 16:48 ` Rajesh Borundia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003.143855.520640065174429479.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agospoda@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=rajesh.borundia@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).