From: David Miller <davem@davemloft.net>
To: s.munaut@whatever-company.com
Cc: amwang@redhat.com, netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [Patch net-next] netpoll: call ->ndo_select_queue() in tx path
Date: Wed, 03 Oct 2012 14:39:21 -0400 (EDT) [thread overview]
Message-ID: <20121003.143921.697266851720404652.davem@davemloft.net> (raw)
In-Reply-To: <CAF6-1L5Gp9kpV+Koru6uAmYxQg_WQav9RVD4MVBDa2UGSoPOCA@mail.gmail.com>
From: Sylvain Munaut <s.munaut@whatever-company.com>
Date: Wed, 3 Oct 2012 11:33:22 +0200
> Hi,
>
>>> In netpoll tx path, we miss the chance of calling ->ndo_select_queue(),
>>> thus could cause problems when bonding is involved.
>>>
>>> This patch makes dev_pick_tx() extern (and rename it to netdev_pick_tx())
>>> to let netpoll call it in netpoll_send_skb_on_dev().
>>>
>>> Reported-by: Sylvain Munaut <s.munaut@whatever-company.com>
>>> Cc: "David S. Miller" <davem@davemloft.net>
>>> Cc: Eric Dumazet <edumazet@google.com>
>>> Signed-off-by: Cong Wang <amwang@redhat.com>
>>> Tested-by: Sylvain Munaut <s.munaut@whatever-company.com>
>>
>> Applied, thanks.
>
> Huh, I don't see it in the final 3.6 ?
> That's rather inconvenient :(
What part of "net-next" in the subject line do you not understand?
next prev parent reply other threads:[~2012-10-03 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 6:16 [Patch net-next] netpoll: call ->ndo_select_queue() in tx path Cong Wang
2012-09-19 21:21 ` David Miller
2012-10-03 9:33 ` Sylvain Munaut
2012-10-03 18:39 ` David Miller [this message]
2012-10-07 14:34 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003.143921.697266851720404652.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=s.munaut@whatever-company.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).