From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
Date: Wed, 3 Oct 2012 12:46:52 +0200 [thread overview]
Message-ID: <20121003104652.GK1390@axis.com> (raw)
In-Reply-To: <20120928130608.GA5158@localhost>
On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote:
> Hi Jesper,
Hi!
> FYI, a rather old build bug that's introduced by
>
> bafef0a cris build fixes: update eth_v10.c ethernet driver
>
> All error/warnings:
>
> drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
> drivers/net/cris/eth_v10.c:1131:1: note: declared here
Yep, I can't figure out why the followup patches never reached mainline,
but we have fixes for exactly that in our in-house tree.
I'll push some move patches after this merge window.
> vim +1715 drivers/net/cris/eth_v10.c
>
> ^1da177e (Linus Torvalds 2005-04-16 1710)
> bafef0ae (Jesper Nilsson 2007-11-14 1711) #ifdef CONFIG_NET_POLL_CONTROLLER
> bafef0ae (Jesper Nilsson 2007-11-14 1712) static void
> bafef0ae (Jesper Nilsson 2007-11-14 1713) e100_netpoll(struct net_device* netdev)
> bafef0ae (Jesper Nilsson 2007-11-14 1714) {
> bafef0ae (Jesper Nilsson 2007-11-14 @1715) e100rxtx_interrupt(NETWORK_DMA_TX_IRQ_NBR, netdev, NULL);
> bafef0ae (Jesper Nilsson 2007-11-14 1716) }
> bafef0ae (Jesper Nilsson 2007-11-14 1717) #endif
> bafef0ae (Jesper Nilsson 2007-11-14 1718)
> ^1da177e (Linus Torvalds 2005-04-16 1719) static int
> ^1da177e (Linus Torvalds 2005-04-16 1720) etrax_init_module(void)
> ^1da177e (Linus Torvalds 2005-04-16 1721) {
> ^1da177e (Linus Torvalds 2005-04-16 1722) return etrax_ethernet_init();
> ^1da177e (Linus Torvalds 2005-04-16 1723) }
Thanks!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2012-10-03 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 13:06 drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' Fengguang Wu
2012-10-03 10:46 ` Jesper Nilsson [this message]
2012-10-03 18:40 ` David Miller
2012-10-03 20:26 ` Jesper Nilsson
2012-10-05 21:24 ` Jesper Nilsson
2012-10-06 1:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003104652.GK1390@axis.com \
--to=jesper.nilsson@axis.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).