From: David Miller <davem@davemloft.net>
To: peter.senna@gmail.com
Cc: shemminger@vyatta.com, mlindner@marvell.com,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code
Date: Thu, 04 Oct 2012 14:54:19 -0400 (EDT) [thread overview]
Message-ID: <20121004.145419.1859367129463136197.davem@davemloft.net> (raw)
In-Reply-To: <CA+MoWDqBF5bdQYBaUmpB99Q=YcHYcUxi8Ffo3x4s0B+pmomb+Q@mail.gmail.com>
From: Peter Senna Tschudin <peter.senna@gmail.com>
Date: Thu, 4 Oct 2012 20:49:57 +0200
> On Thu, Oct 4, 2012 at 8:23 PM, David Miller <davem@davemloft.net> wrote:
>> From: Peter Senna Tschudin <peter.senna@gmail.com>
>> Date: Thu, 4 Oct 2012 19:32:12 +0200
>>
>>> I can't understand the advantages of describing each patch as you are
>>> asking. "For me" the generic commit message together with the patch
>>> makes sense. Can you please help me on that?
>>
>> Stop being so dense.
>>
>> We want to know the implications of the bug being fixed.
>>
>> Does it potentially cause an OOPS? Bad reference counting and thus
>> potential leaks or early frees?
>>
>> You have to analyze the implications and ramifications of the bug
>> being fixed. We need that information.
>>
>> Your commit messages are in fact robotic, they don't describe the
>> salient details of what kinds of problems the bug being fixed might
>> cause.
>>
>> It's just "bad error code, this is the script that fixed it, kthx,
>> bye" which is pretty much useless for anaylsis.
>
> Thank you David.
>
> What about this as commit message?
> --- // --
> This patch fixes bug(s) related to return value of function(s). In
> some error cases, the function is returning non-negative SUCCESS
> value, when the correct would be negative ERROR value.
>
> When on error, returning non negatives values, or SUCCESS, breaks error
> propagation, producing unpredictable behavior that are very difficult
> to debug.
> --- // --
What does it potentially cause the caller to do? Will it potentially
treat an error as a success and as a result register an object
illegally?
Real analysis please. The text you provided above is basically still
robotic and could be used to describe any error code return fix.
next prev parent reply other threads:[~2012-10-04 18:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 16:18 [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Peter Senna Tschudin
2012-10-03 16:25 ` Stephen Hemminger
2012-10-03 18:48 ` David Miller
2012-10-04 9:05 ` Peter Senna Tschudin
2012-10-04 14:44 ` Stephen Hemminger
2012-10-04 17:32 ` Peter Senna Tschudin
2012-10-04 17:40 ` Stephen Hemminger
2012-10-04 18:13 ` Peter Senna Tschudin
2012-10-04 18:23 ` David Miller
2012-10-04 18:49 ` Peter Senna Tschudin
2012-10-04 18:54 ` David Miller [this message]
2012-10-05 0:09 ` Joe Perches
2012-10-05 5:22 ` Julia Lawall
2012-10-05 7:36 ` Joe Perches
2012-10-05 8:02 ` Dan Carpenter
2012-10-05 8:08 ` Julia Lawall
2012-10-10 17:08 ` Peter Senna Tschudin
2012-10-10 17:40 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004.145419.1859367129463136197.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).