From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: linux-sctp@vger.kernel.org, vyasevich@gmail.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] sctp: check src addr when processing SACK to update transport state
Date: Thu, 04 Oct 2012 15:54:06 -0400 (EDT) [thread overview]
Message-ID: <20121004.155406.294964504763861852.davem@davemloft.net> (raw)
In-Reply-To: <1349279002-4008-2-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 3 Oct 2012 17:43:22 +0200
> Suppose we have an SCTP connection with two paths. After connection is
> established, path1 is not available, thus this path is marked as inactive. Then
> traffic goes through path2, but for some reasons packets are delayed (after
> rto.max). Because packets are delayed, the retransmit mechanism will switch
> again to path1. At this time, we receive a delayed SACK from path2. When we
> update the state of the path in sctp_check_transmitted(), we do not take into
> account the source address of the SACK, hence we update the wrong path.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied.
next prev parent reply other threads:[~2012-10-04 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 15:43 [RFC PATCH 1/2] sctp: fix a typo in prototype of __sctp_rcv_lookup() Nicolas Dichtel
2012-10-03 15:43 ` [RFC PATCH 2/2] sctp: check src addr when processing SACK to update transport state Nicolas Dichtel
2012-10-04 17:03 ` Vlad Yasevich
2012-10-04 19:54 ` David Miller [this message]
2012-10-03 20:28 ` [RFC PATCH 1/2] sctp: fix a typo in prototype of __sctp_rcv_lookup() David Miller
2012-10-04 7:17 ` Nicolas Dichtel
2012-10-04 17:04 ` Vlad Yasevich
2012-10-05 7:37 ` Nicolas Dichtel
2012-10-04 19:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004.155406.294964504763861852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).