From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC PATCH 2/2] sctp: check src addr when processing SACK to update transport state Date: Thu, 04 Oct 2012 15:54:06 -0400 (EDT) Message-ID: <20121004.155406.294964504763861852.davem@davemloft.net> References: <1349279002-4008-1-git-send-email-nicolas.dichtel@6wind.com> <1349279002-4008-2-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-sctp@vger.kernel.org, vyasevich@gmail.com, netdev@vger.kernel.org To: nicolas.dichtel@6wind.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45390 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757249Ab2JDTyI (ORCPT ); Thu, 4 Oct 2012 15:54:08 -0400 In-Reply-To: <1349279002-4008-2-git-send-email-nicolas.dichtel@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nicolas Dichtel Date: Wed, 3 Oct 2012 17:43:22 +0200 > Suppose we have an SCTP connection with two paths. After connection is > established, path1 is not available, thus this path is marked as inactive. Then > traffic goes through path2, but for some reasons packets are delayed (after > rto.max). Because packets are delayed, the retransmit mechanism will switch > again to path1. At this time, we receive a delayed SACK from path2. When we > update the state of the path in sctp_check_transmitted(), we do not take into > account the source address of the SACK, hence we update the wrong path. > > Signed-off-by: Nicolas Dichtel Applied.