From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com,
ying.xue@windriver.com, paul.gortmaker@windriver.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH v2] tipc: prevent dropped connections due to rcvbuf overflow
Date: Thu, 04 Oct 2012 15:55:03 -0400 (EDT) [thread overview]
Message-ID: <20121004.155503.97946024839188830.davem@davemloft.net> (raw)
In-Reply-To: <1349362843-25826-1-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Thu, 4 Oct 2012 17:00:43 +0200
> From: Erik Hugne <erik.hugne@ericsson.com>
>
> When large buffers are sent over connected TIPC sockets, it
> is likely that the sk_backlog will be filled up on the
> receiver side, but the TIPC flow control mechanism is happily
> unaware of this since that is based on message count.
>
> The sender will receive a TIPC_ERR_OVERLOAD message when this occurs
> and drop it's side of the connection, leaving it stale on
> the receiver end.
>
> By increasing the sk_rcvbuf to a 'worst case' value, we avoid the
> overload caused by a full backlog queue and the flow control
> will work properly.
>
> This worst case value is the max TIPC message size times
> the flow control window, multiplied by two because a sender
> will transmit up to double the window size before a port is marked
> congested.
> We multiply this by 2 to account for the sk_buff and other overheads.
>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Applied.
prev parent reply other threads:[~2012-10-04 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 9:14 [PATCH] tipc: flow control should not account for sk_rcvbuf erik.hugne
2012-10-04 9:21 ` Eric Dumazet
2012-10-04 9:59 ` Erik Hugne
2012-10-04 10:26 ` Eric Dumazet
2012-10-04 12:12 ` Erik Hugne
2012-10-04 13:55 ` Eric Dumazet
2012-10-04 15:00 ` [PATCH v2] tipc: prevent dropped connections due to rcvbuf overflow erik.hugne
2012-10-04 19:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004.155503.97946024839188830.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).