From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipv6: release referenct of ip6_null_entry's dst entry in __ip6_del_rt Date: Thu, 04 Oct 2012 16:00:55 -0400 (EDT) Message-ID: <20121004.160055.886750901157348519.davem@davemloft.net> References: <20120921.131652.353726055575103840.davem@davemloft.net> <505FE24E.4030204@cn.fujitsu.com> <506CFA96.4050207@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: gaofeng@cn.fujitsu.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45560 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162Ab2JDUA5 (ORCPT ); Thu, 4 Oct 2012 16:00:57 -0400 In-Reply-To: <506CFA96.4050207@cn.fujitsu.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Gao feng Date: Thu, 04 Oct 2012 10:55:18 +0800 > 于 2012年09月24日 12:32, Gao feng 写道: >> 于 2012年09月22日 01:16, David Miller 写道: >>> From: Gao feng >>> Date: Thu, 20 Sep 2012 13:25:34 +0800 >>> >>>> as we hold dst_entry before we call __ip6_del_rt, >>>> so we should alse call dst_release not only return >>>> -ENOENT when the rt6_info is ip6_null_entry. >>>> >>>> and we already hold the dst entry, so I think it's >>>> safe to call dst_release out of the write-read lock. >>>> >>>> Signed-off-by: Gao feng ... > Can you apply this patch? Applied and queued up for -stable, thanks.