From: David Miller <davem@davemloft.net>
To: haicheng.li@linux.intel.com
Cc: fengguang.wu@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'
Date: Sat, 06 Oct 2012 17:17:48 -0400 (EDT) [thread overview]
Message-ID: <20121006.171748.734171045678392820.davem@davemloft.net> (raw)
In-Reply-To: <50706885.1030908@linux.intel.com>
From: Haicheng Li <haicheng.li@linux.intel.com>
Date: Sun, 07 Oct 2012 01:21:09 +0800
> Take IXGBE_PTP as example, it explicitly selects PPS, and also depends
> on EXPERIMENTAL:
> config IXGBE_PTP
> bool "PTP Clock Support"
> default n
> depends on IXGBE && EXPERIMENTAL
> select PPS
> select PTP_1588_CLOCK
>
> So if you stick to use "select" as the convention of such build issue
> fixing, fengguang's build failure would be fixed by:
> + depends on EXPERIMENTAL
> + select PPS
> + select PTP_1588_CLOCK
>
> would you prefer this way?
Yes, I would.
Thanks.
next prev parent reply other threads:[~2012-10-06 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 7:59 [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write' Fengguang Wu
2012-10-06 11:31 ` Francois Romieu
2012-10-06 13:22 ` David Miller
2012-10-06 12:07 ` Haicheng Li
2012-10-06 13:22 ` David Miller
2012-10-06 14:07 ` Haicheng Li
2012-10-06 14:21 ` David Miller
2012-10-06 17:21 ` Haicheng Li
2012-10-06 21:17 ` David Miller [this message]
2012-10-07 14:14 ` [PATCH] Fix PTP dependencies: explicitly select all the possible dependencies Haicheng Li
2012-10-07 18:54 ` David Miller
2012-10-06 14:56 ` [net:master 1/9] pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write' Richard Cochran
[not found] ` <1349670580-11158-1-git-send-email-haicheng.lee@gmail.com>
2012-10-08 11:15 ` [PATCH] pch_pge: Fix build error by selecting all the possible dependencies Haicheng Li
[not found] ` <1349695107-19524-1-git-send-email-haicheng.lee@gmail.com>
2012-10-08 18:48 ` [PATCH] pch_gbe: " David Miller
2012-10-09 9:43 ` Haicheng Li
2012-10-09 17:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006.171748.734171045678392820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).