From: Fengguang Wu <fengguang.wu@intel.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: David Miller <davem@davemloft.net>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
Date: Sat, 6 Oct 2012 09:07:44 +0800 [thread overview]
Message-ID: <20121006010744.GA7525@localhost> (raw)
In-Reply-To: <20121005212422.GA1390@axis.com>
On Fri, Oct 05, 2012 at 11:24:22PM +0200, Jesper Nilsson wrote:
> On Wed, Oct 03, 2012 at 10:26:57PM +0200, Jesper Nilsson wrote:
> > On Wed, Oct 03, 2012 at 08:40:40PM +0200, David Miller wrote:
> > > From: Jesper Nilsson <jesper.nilsson@axis.com>
> > > Date: Wed, 3 Oct 2012 12:46:52 +0200
> > >
> > > > On Fri, Sep 28, 2012 at 03:06:08PM +0200, Fengguang Wu wrote:
> > > >> Hi Jesper,
> > > >
> > > > Hi!
> > > >
> > > >> FYI, a rather old build bug that's introduced by
> > > >>
> > > >> bafef0a cris build fixes: update eth_v10.c ethernet driver
> > > >>
> > > >> All error/warnings:
> > > >>
> > > >> drivers/net/cris/eth_v10.c: In function 'e100_netpoll':
> > > >> drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt'
> > > >> drivers/net/cris/eth_v10.c:1131:1: note: declared here
> > > >
> > > > Yep, I can't figure out why the followup patches never reached mainline,
> > > > but we have fixes for exactly that in our in-house tree.
> > > > I'll push some move patches after this merge window.
> > >
> > > It's a bug fix, even worse a build fix, why want until after the merge
> > > window?
> >
> > Aye, true, I'll just have to make sure I don't get any other change from
> > the inhouse tree.
>
> Turns out this was already fixed in mainline since August.
Embarrassing.. It must be testing some git tree that's based on one
upstream HEAD sometime between where the bug was introduced and where
it's fixed.
Thanks,
Fengguang
prev parent reply other threads:[~2012-10-06 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 13:06 drivers/net/cris/eth_v10.c:1715:2: error: too many arguments to function 'e100rxtx_interrupt' Fengguang Wu
2012-10-03 10:46 ` Jesper Nilsson
2012-10-03 18:40 ` David Miller
2012-10-03 20:26 ` Jesper Nilsson
2012-10-05 21:24 ` Jesper Nilsson
2012-10-06 1:07 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121006010744.GA7525@localhost \
--to=fengguang.wu@intel.com \
--cc=davem@davemloft.net \
--cc=jesper.nilsson@axis.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).