From: David Miller <davem@davemloft.net>
To: florz@florz.de
Cc: kaber@trash.net, eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jpirko@redhat.com
Subject: Re: [PATCH v2] vlan: don't deliver frames for unknown vlans to protocols
Date: Mon, 08 Oct 2012 14:42:30 -0400 (EDT) [thread overview]
Message-ID: <20121008.144230.1404596032615788891.davem@davemloft.net> (raw)
In-Reply-To: <20121008015158.GE25895@florz.florz.dyndns.org>
From: Florian Zumbiehl <florz@florz.de>
Date: Mon, 8 Oct 2012 03:51:58 +0200
> This version completely avoids any new state that could need to be spilled
> to RAM, and instead re-checks existence and non-zeroness of the tag. What
> do you think?
At a high level it looks fine and doesn't have the problems mentioned
earlier.
But I wonder if it breaks things, since you do the assignment so late
we no longer handle the case where the VLAN device's MAC address
matches the packet MAC address and the top-level device's does not.
That's handled by logic in vlan_do_receive() which checks for
PACKET_OTHERHOST.
But you're going to unconditionally set PACKET_OTHERHOST, overriding
any decision that code makes.
This turns out to be a really non-trivial area and it's going to take
some time to get this right and audit the change appropriately.
next prev parent reply other threads:[~2012-10-08 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 1:51 [PATCH v2] vlan: don't deliver frames for unknown vlans to protocols Florian Zumbiehl
2012-10-08 18:42 ` David Miller [this message]
2012-10-08 19:19 ` Florian Zumbiehl
2012-10-08 19:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008.144230.1404596032615788891.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=florz@florz.de \
--cc=jpirko@redhat.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox