netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] ipv4: pmtu fixes
Date: Mon, 08 Oct 2012 14:47:13 -0400 (EDT)	[thread overview]
Message-ID: <20121008.144713.729746528422701623.davem@davemloft.net> (raw)
In-Reply-To: <20121008084642.GB15622@secunet.com>

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Mon, 8 Oct 2012 10:46:42 +0200

> This patchset fixes some issues that came with the routing cache removal.
> 
> 1) IPsec and others (udp, ipvs) may cache output routes, these routes
> need to be invalidated on pmtu events in the same way e.g. tcp socket
> cached routes are invalidated. With this we always invalidate or update
> (if we already use a nh exeption route) the old route on pmtu events. 
> 
> This has the drawback that we may needlessly invalidate an uncached route,
> but this fixes all the users that cache routes and pmtu events are rare, so
> this should not be a real issue.
> 
> 2) We create nh exeptions if a user (e.g. tracepath) tries to do pmtu
> dicsovery with packets bigger than the output device mtu. The device mtu
> is not learned and does not expire, so don't create an exeption route.
> 
> 3) We report cached pmtu values to userspace even if they are expired.
> Fix this by checking for expiration before we report.

All applied and queued up for -stable, thanks!

      parent reply	other threads:[~2012-10-08 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08  8:46 [PATCH 0/3] ipv4: pmtu fixes Steffen Klassert
2012-10-08  8:47 ` [PATCH 1/3] ipv4: Always invalidate or update the route on pmtu events Steffen Klassert
2012-10-08  8:48 ` [PATCH 2/3] ipv4: Don't create nh exeption when the device mtu is smaller than the reported pmtu Steffen Klassert
2012-10-08  8:48 ` [PATCH 3/3] ipv4: Don't report stale pmtu values to userspace Steffen Klassert
2012-10-08  9:55   ` Eric Dumazet
2012-10-08 10:38     ` Steffen Klassert
2012-10-08 10:56     ` [PATCH v2 " Steffen Klassert
2012-10-08 18:47 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121008.144713.729746528422701623.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).