netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vxlan: fix more sparse warnings
       [not found] <20121007123635.GB24374@localhost>
@ 2012-10-08 21:55 ` Stephen Hemminger
  2012-10-08 21:58   ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2012-10-08 21:55 UTC (permalink / raw)
  To: Fengguang Wu, David Miller; +Cc: kernel-janitors, netdev

Fix a couple harmless sparse warnings reported by Fengguang Wu.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
Later patches will fix the other warnings as a side effect of more substantial
changes.

--- a/drivers/net/vxlan.c	2012-10-08 13:41:36.920210233 -0700
+++ b/drivers/net/vxlan.c	2012-10-08 13:44:05.630729809 -0700
@@ -1084,13 +1084,13 @@ static int vxlan_fill_info(struct sk_buf
 	if (nla_put_u32(skb, IFLA_VXLAN_ID, vxlan->vni))
 		goto nla_put_failure;
 
-	if (vxlan->gaddr && nla_put_u32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
+	if (vxlan->gaddr && nla_put_be32(skb, IFLA_VXLAN_GROUP, vxlan->gaddr))
 		goto nla_put_failure;
 
 	if (vxlan->link && nla_put_u32(skb, IFLA_VXLAN_LINK, vxlan->link))
 		goto nla_put_failure;
 
-	if (vxlan->saddr && nla_put_u32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
+	if (vxlan->saddr && nla_put_be32(skb, IFLA_VXLAN_LOCAL, vxlan->saddr))
 		goto nla_put_failure;
 
 	if (nla_put_u8(skb, IFLA_VXLAN_TTL, vxlan->ttl) ||

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] vxlan: fix more sparse warnings
  2012-10-08 21:55 ` [PATCH] vxlan: fix more sparse warnings Stephen Hemminger
@ 2012-10-08 21:58   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-10-08 21:58 UTC (permalink / raw)
  To: shemminger; +Cc: fengguang.wu, kernel-janitors, netdev

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Oct 2012 14:55:30 -0700

> Fix a couple harmless sparse warnings reported by Fengguang Wu.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied, thanks Stephen.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-08 21:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20121007123635.GB24374@localhost>
2012-10-08 21:55 ` [PATCH] vxlan: fix more sparse warnings Stephen Hemminger
2012-10-08 21:58   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).