From: David Miller <davem@davemloft.net>
To: jeff.liu@oracle.com
Cc: rds-devel@oss.oracle.com, venkat.x.venkatsubra@oracle.com,
dan.carpenter@oracle.com, james.l.morris@oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] RDS: fix rds-ping spinlock recursion
Date: Tue, 09 Oct 2012 13:58:08 -0400 (EDT) [thread overview]
Message-ID: <20121009.135808.69869742229483434.davem@davemloft.net> (raw)
In-Reply-To: <5073AEB7.9060309@oracle.com>
From: Jeff Liu <jeff.liu@oracle.com>
Date: Tue, 09 Oct 2012 12:57:27 +0800
> This is the revised patch for fixing rds-ping spinlock recursion according to Venkat's suggestions.
>
> RDS ping/pong over TCP feature has been broken for years(2.6.39 to 3.6.0) since we
> have to set TCP cork and call kernel_sendmsg() between ping/pong which both need to
> lock "struct sock *sk". However, this lock has already been hold before rds_tcp_data_ready()
> callback is triggerred. As a result, we always facing spinlock resursion which would resulting
> in system panic.
>
> Given that RDS ping is only used to test the connectivity and not for serious performance measurements,
> we can queue the pong transmit to rds_wq as a delayed response.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> CC: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
> CC: David S. Miller <davem@davemloft.net>
> CC: James Morris <james.l.morris@oracle.com>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-10-09 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 4:57 [PATCH v2] RDS: fix rds-ping spinlock recursion Jeff Liu
2012-10-09 17:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009.135808.69869742229483434.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=james.l.morris@oracle.com \
--cc=jeff.liu@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=venkat.x.venkatsubra@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).