netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
@ 2012-10-12  5:57 Niels Baggesen
  2012-10-12  6:26 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Niels Baggesen @ 2012-10-12  5:57 UTC (permalink / raw)
  To: netdev

The subject line says it all:

Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6

Signed-off-by: Niels Baggesen <nba@users.sourceforge.net>


--- net/ipv6/proc.c.orig    2012-10-01 12:52:09.452543199 +0200
+++ net/ipv6/proc.c    2012-10-01 12:53:19.794660628 +0200
@@ -90,6 +90,8 @@
      SNMP_MIB_ITEM("Ip6OutMcastOctets", IPSTATS_MIB_OUTMCASTOCTETS),
      SNMP_MIB_ITEM("Ip6InBcastOctets", IPSTATS_MIB_INBCASTOCTETS),
      SNMP_MIB_ITEM("Ip6OutBcastOctets", IPSTATS_MIB_OUTBCASTOCTETS),
+     SNMP_MIB_ITEM("Ip6InBcastPkts", IPSTATS_MIB_INBCASTPKTS),
+     SNMP_MIB_ITEM("Ip6OutBcastPkts", IPSTATS_MIB_OUTBCASTPKTS),
      SNMP_MIB_SENTINEL
  };

/Niels

-- 
Niels Baggesen - @home - Århus - Denmark - nba@users.sourceforge.net
The purpose of computing is insight, not numbers   ---   R W Hamming

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
  2012-10-12  5:57 [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6 Niels Baggesen
@ 2012-10-12  6:26 ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-10-12  6:26 UTC (permalink / raw)
  To: nba; +Cc: netdev

From: Niels Baggesen <nba@users.sourceforge.net>
Date: Fri, 12 Oct 2012 01:57:41 -0400

> The subject line says it all:

Your email client corrupted your patch.

Fix this, and email yourself the patch validating that what you
receive you can apply successfully.

Only after you can do this should you resubmit your patch here.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
       [not found] <S1754091Ab2JLF5l/20121012055741Z+350@vger.kernel.org>
@ 2012-10-12  6:30 ` Eric Dumazet
  0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-10-12  6:30 UTC (permalink / raw)
  To: Niels Baggesen; +Cc: netdev

On Fri, 2012-10-12 at 01:57 -0400, Niels Baggesen wrote:
> The subject line says it all:
> 
> Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6
> 
> Signed-off-by: Niels Baggesen <nba@users.sourceforge.net>
> 
> 
> --- net/ipv6/proc.c.orig    2012-10-01 12:52:09.452543199 +0200
> +++ net/ipv6/proc.c    2012-10-01 12:53:19.794660628 +0200
> @@ -90,6 +90,8 @@
>       SNMP_MIB_ITEM("Ip6OutMcastOctets", IPSTATS_MIB_OUTMCASTOCTETS),
>       SNMP_MIB_ITEM("Ip6InBcastOctets", IPSTATS_MIB_INBCASTOCTETS),
>       SNMP_MIB_ITEM("Ip6OutBcastOctets", IPSTATS_MIB_OUTBCASTOCTETS),
> +     SNMP_MIB_ITEM("Ip6InBcastPkts", IPSTATS_MIB_INBCASTPKTS),
> +     SNMP_MIB_ITEM("Ip6OutBcastPkts", IPSTATS_MIB_OUTBCASTPKTS),
>       SNMP_MIB_SENTINEL
>   };
> 
> /Niels
> 

And does it give useful information ?

As far as I know, IPv6 doesnt increment these counters, but I might be
wrong.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-12  6:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-12  5:57 [PATCH] Ip6{In,Out}BcastPkts statistics missing from /proc/net/snmp6 Niels Baggesen
2012-10-12  6:26 ` David Miller
     [not found] <S1754091Ab2JLF5l/20121012055741Z+350@vger.kernel.org>
2012-10-12  6:30 ` Eric Dumazet

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).