From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Måns Rullgård" <mans@mansr.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
David Laight <David.Laight@aculab.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, Jon Masters <jonathan@jonmasters.org>
Subject: Re: alignment faults in 3.6
Date: Fri, 12 Oct 2012 12:07:50 +0100 [thread overview]
Message-ID: <20121012110750.GE21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <yw1xhaq0nefg.fsf@unicorn.mansr.com>
On Fri, Oct 12, 2012 at 12:00:03PM +0100, Måns Rullgård wrote:
> Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
>
> > On Fri, Oct 12, 2012 at 08:11:42AM +0000, Arnd Bergmann wrote:
> >> On Thursday 11 October 2012, Måns Rullgård wrote:
> >> > > But, the IP header is expected to be aligned.
> >> >
> >> > Everything tells the compiler the struct is perfectly aligned. When the
> >> > buggy driver passes a misaligned pointer, bad things happen.
> >>
> >> Would it be appropriate to add a WARN_ON_ONCE() in the alignment fault path
> >> then?
>
> I think that's an excellent idea.
Well, I get the last word here and it's no.
> >> If all alignment faults in the kernel are caused by broken drivers,
> >> that would at least give us some hope of finding those drivers while
> >> at the same time not causing much overhead in the case where we need
> >> to do the fixup in the meantime.
> >
> > No. It is my understanding that various IP option processing can also
> > cause the alignment fault handler to be invoked, even when the packet is
> > properly aligned, and then there's jffs2/mtd which also relies upon
> > alignment faults being fixed up.
>
> As far as I'm concerned, this is all hearsay, and I've only ever heard
> it from you. Why can't you let those who care fix these bugs instead?
You know, I'm giving you the benefit of my _knowledge_ which has been
built over the course of the last 20 years. I've been in these
discussions with networking people before. I ended up having to develop
the alignment fault handler because of those discussions. And oh look,
Eric confirmed that the networking code isn't going to get "fixed" as
you were demanding, which is exactly what I said.
I've been in discussions with MTD people over these issues before, I've
discussed this with David Woodhouse when it came up in JFFS2. I *KNOW*
these things.
You can call it hearsay if you wish, but it seems to be more accurate
than your wild outlandish and pathetic statements.
next prev parent reply other threads:[~2012-10-12 11:08 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <506E1762.3010601@gmail.com>
[not found] ` <CANLjY-no-L9=LRCvCetC5XCHicOoSWOfRZmUd7itAiUHWBhAyw@mail.gmail.com>
[not found] ` <CAG5Tg6Wuybruc31x1eh6mFafsg=7cOgYLgpZUBuJUo75ap3osQ@mail.gmail.com>
[not found] ` <506E3E58.80703@gmail.com>
[not found] ` <CAG5Tg6V0Vj9HTy3=AU-q+Qa3DuJs6R1Kw+3uOWU_jOGfkgyXzw@mail.gmail.com>
[not found] ` <20121005071216.GD4625@n2100.arm.linux.org.uk>
[not found] ` <CAG5Tg6VciuxJ=k+fatzLugcehF54mGNOLHpUwdMX99oCnAVg8Q@mail.gmail.com>
[not found] ` <20121005082439.GF4625@n2100.arm.linux.org.uk>
[not found] ` <506ED18C.3010009@gmail.com>
[not found] ` <20121005140556.GQ4625@n2100.arm.linux.org.uk>
[not found] ` <506EEFBB.3060705@gmail.com>
[not found] ` <507619FA.6080001@jonmasters.org>
2012-10-11 2:27 ` alignment faults in 3.6 Måns Rullgård
2012-10-11 2:34 ` Jon Masters
2012-10-11 8:21 ` David Laight
2012-10-11 8:53 ` Russell King - ARM Linux
2012-10-11 9:45 ` Måns Rullgård
2012-10-11 10:00 ` Eric Dumazet
2012-10-11 10:20 ` Måns Rullgård
2012-10-11 10:22 ` Eric Dumazet
2012-10-11 10:32 ` Russell King - ARM Linux
2012-10-11 10:49 ` Eric Dumazet
2012-10-11 10:56 ` Maxime Bizon
2012-10-11 11:28 ` Eric Dumazet
2012-10-11 11:47 ` Maxime Bizon
2012-10-11 11:54 ` Eric Dumazet
2012-10-11 12:00 ` Eric Dumazet
2012-10-11 12:51 ` Maxime Bizon
2012-10-11 12:59 ` Eric Dumazet
2012-10-11 12:28 ` Arnd Bergmann
2012-10-11 12:40 ` Eric Dumazet
2012-10-11 13:20 ` Rob Herring
2012-10-11 13:32 ` Måns Rullgård
2012-10-11 13:35 ` Arnd Bergmann
2012-10-11 13:47 ` Eric Dumazet
2012-10-11 15:23 ` Rob Herring
2012-10-11 15:39 ` David Laight
2012-10-11 16:18 ` Måns Rullgård
2012-10-12 8:11 ` Arnd Bergmann
2012-10-12 9:03 ` Russell King - ARM Linux
2012-10-12 10:04 ` Eric Dumazet
2012-10-12 12:24 ` Russell King - ARM Linux
2012-10-12 11:00 ` Måns Rullgård
2012-10-12 11:07 ` Russell King - ARM Linux [this message]
2012-10-12 11:18 ` Måns Rullgård
2012-10-12 11:44 ` Russell King - ARM Linux
2012-10-12 12:08 ` Eric Dumazet
2012-10-12 14:22 ` Benjamin LaHaise
2012-10-12 14:36 ` David Laight
2012-10-12 14:48 ` Eric Dumazet
2012-10-12 15:00 ` Benjamin LaHaise
2012-10-12 15:04 ` Ben Hutchings
2012-10-12 15:47 ` David Laight
2012-10-12 16:13 ` Ben Hutchings
2012-10-12 12:16 ` Måns Rullgård
2012-10-12 11:19 ` Russell King - ARM Linux
2012-10-11 16:15 ` Eric Dumazet
2012-10-11 16:59 ` Catalin Marinas
2012-10-11 10:16 ` David Laight
2012-10-11 10:46 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012110750.GE21164@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=David.Laight@aculab.com \
--cc=arnd@arndb.de \
--cc=eric.dumazet@gmail.com \
--cc=jonathan@jonmasters.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).