Re: [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit

Rob Herring
2012-10-11T15:47:00Z

On 10/11/2012 10:27 AM, Thomas Petazzoni wrote:
> This patch contains a new network driver for the network unit of the
> ARM Marvell Armada 370 and the Armada XP. Both SoCs use the PJ4B
> processor, a Marvell-developed ARM core that implements the ARMv7
> instruction set.

> diff --git a/Documentation/devicetree/bindings/net/marvell-neta.txt b/Documentation/devicetree/bindings/net/marvell-neta.txt
> new file mode 100644
> index 0000000..a031978
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/marvell-neta.txt
> @@ -0,0 +1,24 @@
> +* Marvell Armada 370 / Armada XP Ethernet Controller (NETA)
> +
> +Required properties:
> +- compatible: should be "marvell,neta".

This should be more specific such as "marvell,armada-xp-neta".

Or use 370 instead of xp. It should be which ever chip came first.

> +- reg: address and length of the register set for the device.
> +- interrupts: interrupt for the device
> +- phy-mode: String, operation mode of the PHY interface. Supported
> + values are "sgmii" and "rmii".
> +- phy-addr: Integer, address of the PHY.
> +- device_type: should be "network".

Drop this. device_type is not used for FDT.

> +- clock-frequency: frequency of the peripheral clock of the SoC.
> +
> +Example:
> +
> +eth@d0070000 {

Should be ethernet@...

Rob