* regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded
@ 2012-10-11 14:28 Jon Stanley
2012-10-11 14:47 ` Jon Stanley
2012-10-14 14:32 ` Jiri Pirko
0 siblings, 2 replies; 3+ messages in thread
From: Jon Stanley @ 2012-10-11 14:28 UTC (permalink / raw)
To: fubar, andy, netdev, linux-kernel, jpirko
Since commit cc0e40700656b09d93b062ef6c818aa45429d09a, there is a
problem if you have the 8021q module loaded and you then attempt to
enslave a VLAN challenged interface. This is because VLAN 0 is
automatically added to the bond, and the new bond_vlan_used() function
simply checks for an empty list in bond->vlan_list without taking into
account that VLAN0 might be on the interface.
This specifically affects IPoIB interfaces in a bond if you do a
down/up cycle on the bond post-boot (during boot, the bonding module
is loaded prior to the 8021q module, so everything is fine).
Let me know if further information or testing is needed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded
2012-10-11 14:28 regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded Jon Stanley
@ 2012-10-11 14:47 ` Jon Stanley
2012-10-14 14:32 ` Jiri Pirko
1 sibling, 0 replies; 3+ messages in thread
From: Jon Stanley @ 2012-10-11 14:47 UTC (permalink / raw)
To: fubar, andy, netdev, linux-kernel, jpirko
On Thu, Oct 11, 2012 at 10:28 AM, Jon Stanley <jstanley@rmrf.net> wrote:
> This specifically affects IPoIB interfaces in a bond if you do a
> down/up cycle on the bond post-boot (during boot, the bonding module
> is loaded prior to the 8021q module, so everything is fine).
I hate replying to myself, but I've just been shown an instance where
it fails to come up at boot. The configuration involves tagged
Ethernet interfaces *and* IPoIB in a bond (obviously with no VLAN's on
the IPoIB bond), I probably wasn't clear on that in my original mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded
2012-10-11 14:28 regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded Jon Stanley
2012-10-11 14:47 ` Jon Stanley
@ 2012-10-14 14:32 ` Jiri Pirko
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2012-10-14 14:32 UTC (permalink / raw)
To: Jon Stanley; +Cc: fubar, andy, netdev, linux-kernel, jpirko
Thu, Oct 11, 2012 at 04:28:40PM CEST, jstanley@rmrf.net wrote:
>Since commit cc0e40700656b09d93b062ef6c818aa45429d09a, there is a
>problem if you have the 8021q module loaded and you then attempt to
>enslave a VLAN challenged interface. This is because VLAN 0 is
>automatically added to the bond, and the new bond_vlan_used() function
>simply checks for an empty list in bond->vlan_list without taking into
>account that VLAN0 might be on the interface.
>
>This specifically affects IPoIB interfaces in a bond if you do a
>down/up cycle on the bond post-boot (during boot, the bonding module
>is loaded prior to the 8021q module, so everything is fine).
>
>Let me know if further information or testing is needed.
Thanks for the report. I just fixed this by following patch:
http://patchwork.ozlabs.org/patch/191363/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-14 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-11 14:28 regression in bonding driver with VLAN challenged interfaces when 8021q module is loaded Jon Stanley
2012-10-11 14:47 ` Jon Stanley
2012-10-14 14:32 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).