From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: richardcochran@gmail.com, haicheng.li@linux.intel.com,
netdev@vger.kernel.org, tshimizu818@gmail.com,
linux-kernel@vger.kernel.org, haicheng.lee@gmail.com
Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.
Date: Tue, 16 Oct 2012 16:17:21 -0400 (EDT) [thread overview]
Message-ID: <20121016.161721.460693104731176775.davem@davemloft.net> (raw)
In-Reply-To: <1350418167.2649.47.camel@bwh-desktop.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 16 Oct 2012 21:09:27 +0100
> I think the various kconfig options should be changed as follows:
>
> 1. Only PTP_1588_CLOCK selects PPS.
> 2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18
> months and it's even being backported to RHEL 6 now.)
> 3. Either:
> (a) The per-driver PHC options select nothing, and the driver options
> do e.g.:
> select PTP_1588_CLOCK if IGB_PTP
> (b) The per-driver PHC options are removed and the driver options do:
> select PTP_1588_CLOCK
> (i.e. PHC support is unconditional)
>
> Any objections to this, or preference for (a) vs (b)?
No objections, prefer (b).
next prev parent reply other threads:[~2012-10-16 20:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <506009A4.8000202@linux.intel.com>
2012-09-25 0:23 ` [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency Haicheng Li
2012-09-27 22:09 ` David Miller
2012-09-28 6:41 ` Haicheng Li
2012-09-28 6:46 ` David Miller
2012-09-28 6:57 ` Haicheng Li
2012-10-03 2:22 ` David Miller
2012-10-03 21:45 ` Ben Hutchings
2012-10-04 0:43 ` David Miller
2012-10-16 20:09 ` Ben Hutchings
2012-10-16 20:17 ` David Miller [this message]
2012-10-16 21:08 ` Keller, Jacob E
[not found] ` <50600A49.7040902@linux.intel.com>
2012-09-25 0:24 ` [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info Haicheng Li
2012-09-27 22:06 ` David Miller
2012-09-28 6:44 ` Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016.161721.460693104731176775.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=haicheng.lee@gmail.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tshimizu818@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).