From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, marcheu@google.com, kliegs@google.com,
sleffler@google.com
Subject: Re: [PATCH] netlink: use kfree_rcu() in netlink_release()
Date: Thu, 18 Oct 2012 15:36:16 -0400 (EDT) [thread overview]
Message-ID: <20121018.153616.732430567959014097.davem@davemloft.net> (raw)
In-Reply-To: <1350566515.26103.1549.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 18 Oct 2012 15:21:55 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> On some suspend/resume operations involving wimax device, we have
> noticed some intermittent memory corruptions in netlink code.
>
> Stéphane Marchesin tracked this corruption in netlink_update_listeners()
> and suggested a patch.
>
> It appears netlink_release() should use kfree_rcu() instead of kfree()
> for the listeners structure as it may be used by other cpus using RCU
> protection.
>
> netlink_release() must set to NULL the listeners pointer when
> it is about to be freed.
>
> Also have to protect netlink_update_listeners() and
> netlink_has_listeners() if listeners is NULL.
>
> Add a nl_deref_protected() lockdep helper to properly document which
> locks protects us.
>
> Reported-by: Jonathan Kliegman <kliegs@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2012-10-18 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 13:21 [PATCH] netlink: use kfree_rcu() in netlink_release() Eric Dumazet
2012-10-18 19:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018.153616.732430567959014097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kliegs@google.com \
--cc=marcheu@google.com \
--cc=netdev@vger.kernel.org \
--cc=sleffler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).