From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, enh@google.com, ncardwell@google.com,
therbert@google.com
Subject: Re: [PATCH] tcp: fix FIONREAD/SIOCINQ
Date: Thu, 18 Oct 2012 15:36:39 -0400 (EDT) [thread overview]
Message-ID: <20121018.153639.105102863572041684.davem@davemloft.net> (raw)
In-Reply-To: <1350587652.32642.215.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 18 Oct 2012 21:14:12 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> tcp_ioctl() tries to take into account if tcp socket received a FIN
> to report correct number bytes in receive queue.
>
> But its flaky because if the application ate the last skb,
> we return 1 instead of 0.
>
> Correct way to detect that FIN was received is to test SOCK_DONE.
>
> Reported-by: Elliot Hughes <enh@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2012-10-18 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 19:14 [PATCH] tcp: fix FIONREAD/SIOCINQ Eric Dumazet
2012-10-18 19:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018.153639.105102863572041684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=enh@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox