From: Serge Hallyn <serge.hallyn@canonical.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().
Date: Fri, 19 Oct 2012 19:07:56 -0500 [thread overview]
Message-ID: <20121020000756.GA29345@sergelap> (raw)
In-Reply-To: <1350644970-2877-1-git-send-email-ramirose@gmail.com>
Quoting Rami Rosen (ramirose@gmail.com):
> This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Yup, sure is a duplicate assignment...
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
> ---
> net/core/dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 09cb3f6..b4978e2 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
> goto out;
>
> /* Ensure the device has been registrered */
> - err = -EINVAL;
> if (dev->reg_state != NETREG_REGISTERED)
> goto out;
>
> --
> 1.7.11.4
>
next prev parent reply other threads:[~2012-10-20 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 11:09 [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace() Rami Rosen
2012-10-20 0:07 ` Serge Hallyn [this message]
2012-10-22 0:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121020000756.GA29345@sergelap \
--to=serge.hallyn@canonical.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).