From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: eric.dumazet@gmail.com, joe@perches.com, bernat@luffy.cx,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next v7 1/1] ipv6: add support of equal cost multipath (ECMP)
Date: Sun, 21 Oct 2012 20:41:46 -0400 (EDT) [thread overview]
Message-ID: <20121021.204146.1395047796384194358.davem@davemloft.net> (raw)
In-Reply-To: <1350638006-4213-2-git-send-email-nicolas.dichtel@6wind.com>
Why do you go through all of the effort to create a nice
abstraction in a header file:
> +#ifdef CONFIG_IPV6_MULTIPATH
> +static inline unsigned int
> +ipv6_multipath_get_nsiblings(const struct rt6_info *rt)
> +{
> + return rt->rt6i_nsiblings;
> +}
...
Only to screw it up by still plopping ifdef crap into foo.c files?
> +#ifdef CONFIG_IPV6_MULTIPATH
> + INIT_LIST_HEAD(&rt->rt6i_siblings);
> +#endif
> + ipv6_multipath_reset_nsiblings(rt);
I really don't want to see these ifdefs.
And if they are unavoidable, remove this configure option
altogether and make the code unconditionally included.
next prev parent reply other threads:[~2012-10-22 0:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 17:30 IPv6 multipath routes Vincent Bernat
2012-09-06 17:30 ` [PATCH] Fix "ip -6 route add ... nexthop" Vincent Bernat
2012-09-06 17:53 ` Vincent Bernat
2012-09-12 8:29 ` [RFC PATCH net-next 0/1] Add support of ECMPv6 Nicolas Dichtel
2012-09-12 8:29 ` [RFC PATCH net-next 1/1] ipv6: add support of ECMP Nicolas Dichtel
2012-09-12 8:48 ` YOSHIFUJI Hideaki
2012-09-12 9:42 ` YOSHIFUJI Hideaki
2012-09-12 9:53 ` Nicolas Dichtel
2012-09-14 7:59 ` [RFC PATCH net-next v2 0/1] Add support of ECMPv6 Nicolas Dichtel
2012-09-14 7:59 ` [RFC PATCH net-next v2 1/1] ipv6: add support of ECMP Nicolas Dichtel
2012-09-14 9:40 ` [RFC PATCH net-next v2 0/1] Add support of ECMPv6 Vincent Bernat
2012-09-14 13:35 ` Nicolas Dichtel
2012-09-14 13:37 ` Nicolas Dichtel
2012-10-15 12:36 ` Vincent Bernat
2012-10-15 19:54 ` Vincent Bernat
2012-09-19 9:18 ` [PATCH net-next v3 " Nicolas Dichtel
2012-09-19 9:18 ` [PATCH net-next v3 1/1] ipv6: add support of ECMP Nicolas Dichtel
2012-09-20 21:15 ` David Miller
2012-09-21 9:59 ` [PATCH net-next v4 0/1] Add support of ECMPv6 Nicolas Dichtel
2012-09-21 9:59 ` [PATCH net-next v4 1/1] ipv6: add support of ECMP Nicolas Dichtel
2012-09-21 17:48 ` [PATCH net-next v4 0/1] Add support of ECMPv6 David Miller
2012-09-24 12:28 ` Nicolas Dichtel
2012-10-01 13:56 ` [PATCH net-next v5 " Nicolas Dichtel
2012-10-01 13:56 ` [PATCH net-next v5 1/1] ipv6: add support of ECMP Nicolas Dichtel
2012-10-01 16:47 ` Joe Perches
2012-10-02 16:02 ` [PATCH net-next v6 0/1] Add support of ECMPv6 Nicolas Dichtel
2012-10-02 16:02 ` [PATCH net-next v6 1/1] ipv6: add support of equal cost multipath (ECMP) Nicolas Dichtel
2012-10-02 16:06 ` Nicolas Dichtel
2012-10-02 16:14 ` Eric Dumazet
2012-10-19 9:13 ` [PATCH net-next v7 0/1] Add support of ECMPv6 nicolas.dichtel
2012-10-19 9:13 ` [PATCH net-next v7 1/1] ipv6: add support of equal cost multipath (ECMP) nicolas.dichtel
2012-10-22 0:41 ` David Miller [this message]
2012-10-22 13:42 ` [PATCH net-next v8 0/1] Add support of ECMPv6 nicolas.dichtel
2012-10-22 13:42 ` [PATCH net-next v8 1/1] ipv6: add support of equal cost multipath (ECMP) nicolas.dichtel
2012-10-23 6:39 ` David Miller
2012-10-23 12:42 ` [PATCH iproute2 1/2] ip: fix "ip -6 route add ... nexthop" Nicolas Dichtel
2012-10-23 12:42 ` [PATCH iproute2 2/2] ip: remove NLM_F_EXCL in case of ECMPv6 routes Nicolas Dichtel
2012-10-25 16:06 ` Stephen Hemminger
2012-10-25 16:20 ` Nicolas Dichtel
2012-10-25 16:25 ` Stephen Hemminger
2012-10-25 16:48 ` Nicolas Dichtel
2012-11-02 8:58 ` [RESEND PATCH net-next] ipv6/multipath: remove flag NLM_F_EXCL after the first nexthop Nicolas Dichtel
2012-11-03 1:38 ` David Miller
2012-11-05 8:30 ` Nicolas Dichtel
2012-10-25 16:08 ` [PATCH iproute2 1/2] ip: fix "ip -6 route add ... nexthop" Stephen Hemminger
2012-10-02 18:43 ` [PATCH net-next v6 1/1] ipv6: add support of equal cost multipath (ECMP) David Miller
2012-09-11 12:57 ` IPv6 multipath routes Ulrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021.204146.1395047796384194358.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bernat@luffy.cx \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).