* [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().
@ 2012-10-19 11:09 Rami Rosen
2012-10-20 0:07 ` Serge Hallyn
2012-10-22 0:45 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2012-10-19 11:09 UTC (permalink / raw)
To: davem, netdev; +Cc: serge.hallyn, Rami Rosen
This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
net/core/dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 09cb3f6..b4978e2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
goto out;
/* Ensure the device has been registrered */
- err = -EINVAL;
if (dev->reg_state != NETREG_REGISTERED)
goto out;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().
2012-10-19 11:09 [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace() Rami Rosen
@ 2012-10-20 0:07 ` Serge Hallyn
2012-10-22 0:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Serge Hallyn @ 2012-10-20 0:07 UTC (permalink / raw)
To: Rami Rosen; +Cc: davem, netdev
Quoting Rami Rosen (ramirose@gmail.com):
> This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Yup, sure is a duplicate assignment...
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
> ---
> net/core/dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 09cb3f6..b4978e2 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
> goto out;
>
> /* Ensure the device has been registrered */
> - err = -EINVAL;
> if (dev->reg_state != NETREG_REGISTERED)
> goto out;
>
> --
> 1.7.11.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().
2012-10-19 11:09 [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace() Rami Rosen
2012-10-20 0:07 ` Serge Hallyn
@ 2012-10-22 0:45 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-10-22 0:45 UTC (permalink / raw)
To: ramirose; +Cc: netdev, serge.hallyn
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 19 Oct 2012 13:09:30 +0200
> This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-22 0:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 11:09 [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace() Rami Rosen
2012-10-20 0:07 ` Serge Hallyn
2012-10-22 0:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).