netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Joachim Eastwood <manabian@gmail.com>
Cc: bgat@billgatliff.com, netdev@vger.kernel.org,
	nicolas.ferre@atmel.com, hskinnemoen@gmail.com,
	davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
	egtvedt@samfundet.no
Subject: Re: [PATCH 1/5] net/cadence: get rid of HAVE_NET_MACB
Date: Sun, 21 Oct 2012 20:30:05 +0200	[thread overview]
Message-ID: <20121021183005.GA18964@game.jcrosoft.org> (raw)
In-Reply-To: <1350829392-3812-2-git-send-email-manabian@gmail.com>

On 16:23 Sun 21 Oct     , Joachim Eastwood wrote:
> macb is a platform driver and there is nothing that prevents
> this driver from being built on non-ARM/AVR32 platforms.
if you want to drop the HAVE_NET_MACB you need to drop it everywher in one
patch

Best Regards,
J.
> 
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
>  drivers/net/ethernet/cadence/Kconfig | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 57f78abe..5d1ea30 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -2,13 +2,9 @@
>  # Atmel device configuration
>  #
>  
> -config HAVE_NET_MACB
> -	bool
> -
>  config NET_CADENCE
>  	bool "Cadence devices"
>  	default y
> -	depends on HAVE_NET_MACB || (ARM && ARCH_AT91RM9200)
>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>  	  Make sure you know the name of your card. Read the Ethernet-HOWTO,
> @@ -34,7 +30,6 @@ config ARM_AT91_ETHER
>  
>  config MACB
>  	tristate "Cadence MACB/GEM support"
> -	depends on HAVE_NET_MACB
>  	select PHYLIB
>  	---help---
>  	  The Cadence MACB ethernet interface is found on many Atmel AT32 and
> -- 
> 1.7.12.4
> 

  reply	other threads:[~2012-10-21 18:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 14:23 [PATCH 0/5] make cadence ethernet drivers build on any architecture Joachim Eastwood
2012-10-21 14:23 ` [PATCH 1/5] net/cadence: get rid of HAVE_NET_MACB Joachim Eastwood
2012-10-21 18:30   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-21 20:26     ` Joachim Eastwood
2012-10-21 23:27   ` David Miller
2012-10-22  6:59     ` Joachim Eastwood
2012-10-22  7:10       ` David Miller
2012-10-21 14:23 ` [PATCH 2/5] net/at91_ether: select MACB in Kconfig Joachim Eastwood
2012-10-21 18:31   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-21 20:27     ` Joachim Eastwood
2012-10-21 14:23 ` [PATCH 3/5] net/at91_ether: move eth addr quirk into csb337 board setup Joachim Eastwood
2012-10-21 18:25   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-21 20:39     ` Joachim Eastwood
2012-10-21 18:34   ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-21 20:30     ` Joachim Eastwood
2012-10-21 14:23 ` [PATCH 4/5] ARM: AT91: Remove HAVE_NET_MACB Joachim Eastwood
2012-10-21 14:23 ` [PATCH 5/5] AVR32: " Joachim Eastwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121021183005.GA18964@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=bgat@billgatliff.com \
    --cc=davem@davemloft.net \
    --cc=egtvedt@samfundet.no \
    --cc=hskinnemoen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=manabian@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).