netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kay@vrfy.org
Cc: cardoe@cardoe.com, kaber@trash.net, netdev@vger.kernel.org,
	systemd-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vlan: set sysfs device_type to 'vlan'
Date: Tue, 23 Oct 2012 13:11:39 -0400 (EDT)	[thread overview]
Message-ID: <20121023.131139.1916916979369476334.davem@davemloft.net> (raw)
In-Reply-To: <CAPXgP10EhtdCT5Bus2+Prfrk0LU3tEeBJq8qq4hK4k=TdiS5qQ@mail.gmail.com>

From: Kay Sievers <kay@vrfy.org>
Date: Tue, 23 Oct 2012 12:34:11 +0200

> On Tue, Oct 23, 2012 at 8:36 AM, David Miller <davem@davemloft.net> wrote:
>> From: Doug Goldstein <cardoe@cardoe.com>
>> Date: Mon, 22 Oct 2012 00:53:57 -0500
>>
>>> Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
>>> applications that query network information via udev to identify vlans
>>> instead of using strrchr().
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>>
>> You're extremely misguided.  This change, in fact, makes it ten times
>> harder for such applications to query such devices.
> 
> That makes not much sense, really. Every new interface would fall into
> that category. At least I can't see any mis-guidance here. The other
> devtypes for the major netif types are not that much older.

Only interfaces which provide a facility available in another way
fall into this category.

Thanks for the scarecrow, but no.

  reply	other threads:[~2012-10-23 17:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22  5:53 [PATCH] vlan: set sysfs device_type to 'vlan' Doug Goldstein
2012-10-23  6:36 ` David Miller
2012-10-23 10:34   ` Kay Sievers
2012-10-23 17:11     ` David Miller [this message]
2012-10-23 16:14   ` Ben Greear
2012-10-23 22:52     ` Ben Hutchings
2012-10-23 23:03       ` Ben Greear
2012-11-05  5:45   ` Doug Goldstein
2012-11-05  5:53     ` David Miller
2012-11-05  6:19       ` Doug Goldstein
2012-11-05  6:44         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121023.131139.1916916979369476334.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cardoe@cardoe.com \
    --cc=kaber@trash.net \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=systemd-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).