netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts
@ 2012-10-15 17:55 Michael S. Tsirkin
  2012-10-21 12:49 ` Michael S. Tsirkin
  0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2012-10-15 17:55 UTC (permalink / raw)
  To: Alexander Graf; +Cc: netdev, stable, kvm, virtualization

We copy head count to a 16 bit field,
this works by chance on LE but on BE
guest gets 0. Fix it up.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alexander Graf <agraf@suse.de>
Cc: stable@kernel.org

---
 drivers/vhost/net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
index 9ab6d47..2bb463c 100644
--- a/drivers/vhost/net.c
+++ b/drivers/vhost/net.c
@@ -448,7 +448,8 @@ static void handle_rx(struct vhost_net *net)
 		.hdr.gso_type = VIRTIO_NET_HDR_GSO_NONE
 	};
 	size_t total_len = 0;
-	int err, headcount, mergeable;
+	int err, mergeable;
+	s16 headcount;
 	size_t vhost_hlen, sock_hlen;
 	size_t vhost_len, sock_len;
 	/* TODO: check that we are running from vhost_worker? */
-- 
MST

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts
  2012-10-15 17:55 [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts Michael S. Tsirkin
@ 2012-10-21 12:49 ` Michael S. Tsirkin
  2012-10-21 23:24   ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2012-10-21 12:49 UTC (permalink / raw)
  To: Alexander Graf; +Cc: netdev, stable, kvm, virtualization

On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote:
> We copy head count to a 16 bit field,
> this works by chance on LE but on BE
> guest gets 0. Fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Tested-by: Alexander Graf <agraf@suse.de>
> Cc: stable@kernel.org

Ping. Dave, could you apply this to -net please?

> ---
>  drivers/vhost/net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 9ab6d47..2bb463c 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -448,7 +448,8 @@ static void handle_rx(struct vhost_net *net)
>  		.hdr.gso_type = VIRTIO_NET_HDR_GSO_NONE
>  	};
>  	size_t total_len = 0;
> -	int err, headcount, mergeable;
> +	int err, mergeable;
> +	s16 headcount;
>  	size_t vhost_hlen, sock_hlen;
>  	size_t vhost_len, sock_len;
>  	/* TODO: check that we are running from vhost_worker? */
> -- 
> MST

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts
  2012-10-21 12:49 ` Michael S. Tsirkin
@ 2012-10-21 23:24   ` David Miller
  2012-10-24 16:24     ` Michael S. Tsirkin
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2012-10-21 23:24 UTC (permalink / raw)
  To: mst; +Cc: netdev, stable, kvm, virtualization

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Sun, 21 Oct 2012 14:49:01 +0200

> On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote:
>> We copy head count to a 16 bit field,
>> this works by chance on LE but on BE
>> guest gets 0. Fix it up.
>> 
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> Tested-by: Alexander Graf <agraf@suse.de>
>> Cc: stable@kernel.org
> 
> Ping. Dave, could you apply this to -net please?

Pinging me but not cc:'ing me?  That's really strange.

What if I operate by just mass deleting things that I'm
not explicitly on the To: or CC: when I'm very backlogged?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts
  2012-10-21 23:24   ` David Miller
@ 2012-10-24 16:24     ` Michael S. Tsirkin
  2012-10-24 18:11       ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2012-10-24 16:24 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, stable, kvm, virtualization

On Sun, Oct 21, 2012 at 07:24:02PM -0400, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Sun, 21 Oct 2012 14:49:01 +0200
> 
> > On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote:
> >> We copy head count to a 16 bit field,
> >> this works by chance on LE but on BE
> >> guest gets 0. Fix it up.
> >> 
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >> Tested-by: Alexander Graf <agraf@suse.de>
> >> Cc: stable@kernel.org
> > 
> > Ping. Dave, could you apply this to -net please?
> 
> Pinging me but not cc:'ing me?  That's really strange.
> 
> What if I operate by just mass deleting things that I'm
> not explicitly on the To: or CC: when I'm very backlogged?

Yes, that was silly. Would you like me to repost the patch?

-- 
MST

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts
  2012-10-24 16:24     ` Michael S. Tsirkin
@ 2012-10-24 18:11       ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-10-24 18:11 UTC (permalink / raw)
  To: mst; +Cc: netdev, stable, kvm, virtualization

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 24 Oct 2012 18:24:38 +0200

> Would you like me to repost the patch?

This question is almost retorical.

I said I don't reliably read things I'm not explicitly CC:'d
on, therefore it's possible (and in fact, likely) I don't have
the patch in my inbox.

What do you think you should do?

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-10-24 18:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 17:55 [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts Michael S. Tsirkin
2012-10-21 12:49 ` Michael S. Tsirkin
2012-10-21 23:24   ` David Miller
2012-10-24 16:24     ` Michael S. Tsirkin
2012-10-24 18:11       ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).