From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH V3 02/21] qlcnic: create seperate file for data path routines
Date: Wed, 24 Oct 2012 23:10:58 -0400 (EDT) [thread overview]
Message-ID: <20121024.231058.2042587746412597890.davem@davemloft.net> (raw)
In-Reply-To: <1351031472-731-3-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Tue, 23 Oct 2012 18:30:53 -0400
> +static inline bool qlcnic_82xx_check(struct qlcnic_adapter *adapter)
> +{
> + return (adapter->pdev->device == PCI_DEVICE_ID_QLOGIC_QLE824X) ? 1 : 0;
> +}
"bool" is either "true" or "false", so return "true" or "false" rather
than "1" or "0"
next prev parent reply other threads:[~2012-10-25 3:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 22:30 [PATCH V3 0/21] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-10-23 22:30 ` [PATCH V3 01/21] qlcnic: move HW specific data to seperate structure Sony Chacko
2012-10-23 22:30 ` [PATCH V3 02/21] qlcnic: create seperate file for data path routines Sony Chacko
2012-10-25 3:10 ` David Miller [this message]
2012-10-23 22:30 ` [PATCH V3 03/21] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-10-23 22:30 ` [PATCH V3 04/21] qlcnic: modify PCI and register access routines Sony Chacko
2012-10-23 22:30 ` [PATCH V3 05/21] qlcnic: change driver hardware interface mechanism Sony Chacko
2012-10-23 22:30 ` [PATCH V3 06/21] qlcnic: macros for common register access Sony Chacko
2012-10-23 22:30 ` [PATCH V3 07/21] qlcnic: update driver resource allocation routines Sony Chacko
2012-10-23 22:30 ` [PATCH V3 08/21] qlcnic: get board name API Sony Chacko
2012-10-23 22:31 ` [PATCH V3 09/21] qlcnic: update NIC partition interface routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 10/21] qlcnic: cleanup unused register interfaces Sony Chacko
2012-10-23 22:31 ` [PATCH V3 11/21] qlcnic: rename module params with module_param_named Sony Chacko
2012-10-23 22:31 ` [PATCH V3 12/21] qlcnic: 83xx memory map and HW access routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 13/21] qlcnic: 83xx data path routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 14/21] qlcnic: 83xx base driver Sony Chacko
2012-10-23 22:31 ` [PATCH V3 15/21] qlcnic: create seperate file for sysfs routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 16/21] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 17/21] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-10-23 22:31 ` [PATCH V3 18/21] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-10-23 22:31 ` [PATCH V3 19/21] qlcnic: common register dump utility Sony Chacko
2012-10-23 22:31 ` [PATCH V3 20/21] qlcnic: 83xx ethtool interface routines Sony Chacko
2012-10-23 22:31 ` [PATCH V3 21/21] qlcnic: update driver version - 5.1.30 Sony Chacko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024.231058.2042587746412597890.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).