From: Richard Cochran <richardcochran@gmail.com>
To: Timur Tabi <B04825@freescale.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Wei Yang <Wei.Yang@windriver.com>,
Manoil Claudiu-B08782 <B08782@freescale.com>
Subject: Re: [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe
Date: Wed, 24 Oct 2012 21:42:08 +0200 [thread overview]
Message-ID: <20121024194207.GA2732@netboy.at.omicron.at> (raw)
In-Reply-To: <50883DB7.4030502@freescale.com>
On Wed, Oct 24, 2012 at 02:12:55PM -0500, Timur Tabi wrote:
> Paul Gortmaker wrote:
> > Even if it makes sense to convert the driver to of_xxx calls,
> > I think the obvious bug should be fixed as a separate commit,
> > so that the -stable folks have something to cherry pick.
>
> Oh, I agree with that. I was just wondering why an OF-enabled driver
> would not use OF calls. I've never seen that before. My instinct is that
> the original developer had no idea what he was doing, but perhaps there is
> a very good reason for the way the driver is written.
Instead of using your instinct, try using your brain instead.
Thanks,
Richard
next prev parent reply other threads:[~2012-10-24 19:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 15:21 [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe Paul Gortmaker
2012-10-24 17:59 ` Tabi Timur-B04825
2012-10-24 19:09 ` Paul Gortmaker
2012-10-24 19:12 ` Timur Tabi
2012-10-24 19:42 ` Richard Cochran [this message]
2012-10-24 20:11 ` Timur Tabi
2012-10-24 20:50 ` Richard Cochran
2012-10-25 11:41 ` wyang1
2012-10-25 20:08 ` Richard Cochran
2012-10-25 20:17 ` Timur Tabi
2012-10-26 10:32 ` Richard Cochran
2012-10-25 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024194207.GA2732@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=B04825@freescale.com \
--cc=B08782@freescale.com \
--cc=Wei.Yang@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).