From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v1 4/5] cgroup: net_cls: Pass in task to sock_update_classid() Date: Thu, 25 Oct 2012 11:11:14 -0700 Message-ID: <20121025181114.GO11442@htj.dyndns.org> References: <1351174619-5096-1-git-send-email-wagi@monom.org> <1351174619-5096-5-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , "David S. Miller" , "Michael S. Tsirkin" , Eric Dumazet , Glauber Costa , Joe Perches , Neil Horman , Stanislav Kinsbursky To: Daniel Wagner Return-path: Content-Disposition: inline In-Reply-To: <1351174619-5096-5-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Oct 25, 2012 at 04:16:58PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > sock_update_classid() assumes that the update operation always are > applied on the current task. sock_update_classid() needs to know on > which tasks to work on in order to be able to migrate task between > cgroups using the struct cgroup_subsys attach() callback. > > Signed-off-by: Daniel Wagner > Cc: "David S. Miller" > Cc: "Michael S. Tsirkin" > Cc: Eric Dumazet > Cc: Glauber Costa > Cc: Joe Perches > Cc: Neil Horman > Cc: Stanislav Kinsbursky > Cc: Tejun Heo > Cc: > Cc: 1-4 look good to me. I have no idea about 5. :) Thanks. -- tejun