From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 net-next] r8169: enable ALDPS for power saving Date: Fri, 26 Oct 2012 02:15:20 -0400 (EDT) Message-ID: <20121026.021520.955480530231877139.davem@davemloft.net> References: <1350893153-18320-1-git-send-email-hayeswang@realtek.com> <1351059843-1464-1-git-send-email-hayeswang@realtek.com> <20121024212003.GA11152@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hayeswang@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jean@google.com To: romieu@fr.zoreil.com Return-path: In-Reply-To: <20121024212003.GA11152@electric-eye.fr.zoreil.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Francois Romieu Date: Wed, 24 Oct 2012 23:20:03 +0200 > Hayes Wang : >> Enable ALDPS function to save power when link down. Note that the >> feature should be set after the other PHY settings. And the firmware >> is necessary. Don't enable it without loading the firmware. >> >> None of the firmware-free chipsets support ALDPS. Neither do the >> RTL8168d/8111d. >> >> For 8136 series, make sure the ALDPS is disabled before loading the >> firmware. For 8168 series, the ALDPS would be disabled automatically >> when loading firmware. You must not disable it directly. >> >> Signed-off-by: Hayes Wang > > Acked-by: Francois Romieu Applied, thanks.