From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v1 3/5] cgroup: net_cls: Remove rcu_read_lock/unlock Date: Fri, 26 Oct 2012 03:42:05 -0400 (EDT) Message-ID: <20121026.034205.1662631947358264771.davem@davemloft.net> References: <1351174619-5096-1-git-send-email-wagi@monom.org> <1351174619-5096-4-git-send-email-wagi@monom.org> <20121025184252.GC15105@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, daniel.wagner-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org To: nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org Return-path: In-Reply-To: <20121025184252.GC15105-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Neil Horman Date: Thu, 25 Oct 2012 14:42:52 -0400 > On Thu, Oct 25, 2012 at 04:16:57PM +0200, Daniel Wagner wrote: >> From: Daniel Wagner >> >> As Eric pointed out: >> "Hey task_cls_classid() has its own rcu protection since commit >> 3fb5a991916091a908d (cls_cgroup: Fix rcu lockdep warning) >> >> So we can safely revert Paul commit (1144182a8757f2a1) >> (We no longer need rcu_read_lock/unlock here)" >> >> Signed-off-by: Daniel Wagner ... > Acked-by: Neil Horman Applied.