From: David Miller <davem@davemloft.net>
To: David.Laight@ACULAB.COM
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next v2 2/5] rtnl/ipv6: use netconf msg to advertise forwarding status
Date: Fri, 26 Oct 2012 05:17:19 -0400 (EDT) [thread overview]
Message-ID: <20121026.051719.783711995394609246.davem@davemloft.net> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B7070@saturn3.aculab.com>
From: "David Laight" <David.Laight@ACULAB.COM>
Date: Fri, 26 Oct 2012 10:03:54 +0100
>> > +static inline int inet6_netconf_msgsize_devconf(int type)
>>
>> Outside of header files, we don't add explicit inlines, we let
>> the compiler decide.
>
> Hmmm.... In my experience it makes bad decisions,
> even for static functions that are only called once.
> And yes, I have checked that the inlined code is smaller
> and faster.
This isn't for you to decide. It's been decided long ago that we're
doing things tree wide doing things this way.
If GCC is not perfect, submit a well formed bug report, don't complain
here.
next prev parent reply other threads:[~2012-10-26 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 9:49 [RFC PATCH net-next 0/1] Allow to monitor protocol configuration Nicolas Dichtel
2012-10-23 9:49 ` [RFC PATCH net-next 1/3] rtnl: add a new type of msg to advertise " Nicolas Dichtel
2012-10-23 9:49 ` [RFC PATCH net-next 2/3] rtnl/ipv6: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-23 17:29 ` David Miller
2012-10-24 16:02 ` [RFC PATCH net-next v2 0/5] Allow to monitor protocol configuration Nicolas Dichtel
2012-10-24 16:02 ` [RFC PATCH net-next v2 1/5] rtnl: add a new type of msg to advertise " Nicolas Dichtel
2012-10-24 16:02 ` [RFC PATCH net-next v2 2/5] rtnl/ipv6: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-26 6:18 ` David Miller
2012-10-26 8:28 ` [PATCH net-next v3 0/5] Allow to monitor protocol configuration Nicolas Dichtel
2012-10-26 8:28 ` [PATCH net-next v3 1/5] rtnl: add a new type of msg to advertise " Nicolas Dichtel
2012-10-26 8:28 ` [PATCH net-next v3 2/5] rtnl/ipv6: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-26 8:28 ` [PATCH net-next v3 3/5] rtnl/ipv6: add support of RTM_GETNETCONF Nicolas Dichtel
2012-10-26 8:28 ` [PATCH net-next v3 4/5] rtnl/ipv4: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-26 8:28 ` [PATCH net-next v3 5/5] rtnl/ipv4: add support of RTM_GETNETCONF Nicolas Dichtel
2012-10-28 23:05 ` [PATCH net-next v3 0/5] Allow to monitor protocol configuration David Miller
2012-10-26 9:03 ` [RFC PATCH net-next v2 2/5] rtnl/ipv6: use netconf msg to advertise forwarding status David Laight
2012-10-26 9:17 ` David Miller [this message]
2012-10-24 16:02 ` [RFC PATCH net-next v2 3/5] rtnl/ipv6: add support of RTM_GETNETCONF Nicolas Dichtel
2012-10-24 16:02 ` [RFC PATCH net-next v2 4/5] rtnl/ipv4: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-24 16:02 ` [RFC PATCH net-next v2 5/5] rtnl/ipv4: add support of RTM_GETNETCONF Nicolas Dichtel
2012-10-26 6:19 ` [RFC PATCH net-next v2 0/5] Allow to monitor protocol configuration David Miller
2012-10-23 9:49 ` [RFC PATCH net-next 3/3] rtnl/ipv4: use netconf msg to advertise forwarding status Nicolas Dichtel
2012-10-23 9:54 ` [RFC PATCH iproute2] ip: allow to monitor netconf messages Nicolas Dichtel
2012-10-23 12:52 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026.051719.783711995394609246.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).