From: Cyril Brulebois <kibi@debian.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8169: Fix WoL on RTL8168d/8111d.
Date: Mon, 29 Oct 2012 01:21:40 +0100 [thread overview]
Message-ID: <20121029002140.GK6195@mraw.org> (raw)
In-Reply-To: <20121028230523.GA26778@electric-eye.fr.zoreil.com>
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
Francois Romieu <romieu@fr.zoreil.com> (29/10/2012):
> Cyril Brulebois <kibi@debian.org> :
> > This regression was spotted between Debian squeeze and Debian wheezy
> > kernels (respectively based on 2.6.32 and 3.2). The fix was inspired
> > by <http://www.spinics.net/lists/netdev/msg178543.html>, using
> > RTL_GIGA_MAC_VER_{25,26} for the RTL8168d/8111d chipset.
>
> If someone experiences problems or has questions about WoL with
> Realtek's 816x chipsets, http://marc.info/?t=132079219400004 would
> imho be a better reference.
Thanks. Should I re-send with that as reference, or will you amend the
patch once you're done with your testing?
> [...]
> > Tested on top of a 3.2.23 kernel.
>
> It should still be relevant for current kernel. I'll give it a try.
FWIW, further testing was suggested on some Debian lists, and 3.2.32
(which includes some commits related to r8169) is also affected.
> [...]
> > It looks like RTL_GIGA_MAC_VER_{25,26} are kinda supposed to go
> > together so I kept both. Florent's testing gave the following results:
> > - RTL_GIGA_MAC_VER_25 only: FAIL.
> > - RTL_GIGA_MAC_VER_26 only: SUCCESS.
> > - RTL_GIGA_MAC_VER_25 + RTL_GIGA_MAC_VER_26: SUCCESS.
>
> I don't understand the VER_25 vs VER_26 difference.
Neither do I. We just figured that it would nice to test all three
cases since those two macros popped up when looking at the 8168D
family.
Mraw,
KiBi.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-10-29 0:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 2:46 [PATCH] r8169: Fix WoL on RTL8168d/8111d Cyril Brulebois
2012-10-28 23:05 ` Francois Romieu
2012-10-29 0:21 ` Cyril Brulebois [this message]
2012-10-29 23:01 ` Francois Romieu
2012-11-01 0:00 ` [PATCH v2] " Cyril Brulebois
2012-11-01 22:21 ` Francois Romieu
2012-11-03 19:16 ` David Miller
2012-11-12 16:38 ` [3.0.y, 3.2.y, 3.4.y] " Jonathan Nieder
2012-11-12 23:03 ` Francois Romieu
2012-11-12 23:27 ` David Miller
2012-11-13 20:24 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029002140.GK6195@mraw.org \
--to=kibi@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).