From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
neilb-l3A5Bk7waGM@public.gmane.org,
fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org,
eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
venkat.x.venkatsubra-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
ccaulfie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mingo-X9Un+BFzKDI@public.gmane.org,
dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
ericvh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org,
lw-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org,
Mathieu Desnoyers
<mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>,
Sasha Levin
<levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ejt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
teigland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH v7 09/16] SUNRPC/cache: use new hashtable implementation
Date: Mon, 29 Oct 2012 09:27:58 -0700 [thread overview]
Message-ID: <20121029092758.1ab87d79.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+55aFzO8DJJP3HBfgqXFac9r3=bYK+_nYe4cuXiNFg-623s6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, 29 Oct 2012 07:49:42 -0700 Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> wrote:
> Because there's no reason to believe that '9' is in any way a worse
> random number than something page-shift-related, is there?
9 is much better than PAGE_SHIFT. PAGE_SIZE can vary by a factor of
16, depending on config.
Everyone thinks 4k, and tests only for that. There's potential for
very large performance and behavior changes when their code gets run
on a 64k PAGE_SIZE machine.
next prev parent reply other threads:[~2012-10-29 16:27 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 19:02 [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Sasha Levin
2012-10-28 19:02 ` [PATCH v7 05/16] mm/huge_memory: use new hashtable implementation Sasha Levin
2012-10-28 19:02 ` [PATCH v7 06/16] tracepoint: " Sasha Levin
2012-10-29 11:35 ` Mathieu Desnoyers
2012-10-29 17:29 ` Sasha Levin
[not found] ` <CA+1xoqce6uJ6wy3+2CBwsLHKnsz4wD0vt8MBEGKCFfXTvuC0Hg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 17:50 ` Mathieu Desnoyers
2012-10-29 18:31 ` Josh Triplett
2012-10-29 18:42 ` Sasha Levin
[not found] ` <CA+1xoqfMrn9zDFMJNFfA0NA86wE_DedD97cP1yJ2UQdTjs3uyQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 18:53 ` Mathieu Desnoyers
2012-10-29 18:58 ` Tejun Heo
[not found] ` <20121029185814.GC4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:01 ` Tejun Heo
[not found] ` <20121029190107.GD4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:10 ` Mathieu Desnoyers
2012-10-29 19:09 ` Sasha Levin
[not found] ` <CA+1xoqcSx04JEXy2aPu4Qt7Zb4iSqXBSjARgMae_FusgzpgnaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 19:12 ` Tejun Heo
[not found] ` <20121029191256.GE4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 19:17 ` Sasha Levin
2012-10-29 19:16 ` Mathieu Desnoyers
[not found] ` <1351450948-15618-1-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-28 19:02 ` [PATCH v7 02/16] userns: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 03/16] mm, ksm: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 04/16] workqueue: " Sasha Levin
[not found] ` <1351450948-15618-4-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 1:25 ` Tejun Heo
2012-10-28 19:02 ` [PATCH v7 07/16] net, 9p: " Sasha Levin
[not found] ` <1351450948-15618-7-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:15 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 10/16] dlm: " Sasha Levin
[not found] ` <1351450948-15618-10-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:46 ` Mathieu Desnoyers
2012-10-29 13:07 ` Mathieu Desnoyers
2012-10-29 15:53 ` Sasha Levin
2012-10-29 16:07 ` Mathieu Desnoyers
2012-10-29 16:23 ` David Teigland
2012-10-28 19:02 ` [PATCH v7 12/16] dm: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 14/16] net, rds: " Sasha Levin
[not found] ` <1351450948-15618-14-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 13:25 ` [PATCH v7 14/16] net,rds: " Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 15/16] openvswitch: " Sasha Levin
2012-10-29 13:29 ` Mathieu Desnoyers
2012-10-29 15:43 ` Sasha Levin
[not found] ` <CA+1xoqfRGhPaBEVh228O5_295bWh8FmcyLSOwq8VE5Dm7i3JHg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 15:59 ` Mathieu Desnoyers
2012-10-29 17:35 ` Sasha Levin
[not found] ` <CA+1xoqcr5xmOkDfqL3P84CNdotOALOhiLRkJjsPCZzijSQUF6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 18:16 ` Mathieu Desnoyers
2012-10-29 18:22 ` Tejun Heo
[not found] ` <20121029182209.GB4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-29 18:35 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 16/16] tracing output: " Sasha Levin
2012-10-28 19:02 ` [PATCH v7 08/16] block,elevator: " Sasha Levin
2012-10-29 1:29 ` Tejun Heo
[not found] ` <1351450948-15618-8-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 12:20 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 09/16] SUNRPC/cache: " Sasha Levin
2012-10-29 12:42 ` Mathieu Desnoyers
2012-10-29 14:49 ` Linus Torvalds
2012-10-29 15:13 ` Mathieu Desnoyers
2012-10-29 15:16 ` J. Bruce Fields
[not found] ` <20121029151653.GC9502-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-10-29 15:41 ` Mathieu Desnoyers
[not found] ` <CA+55aFzO8DJJP3HBfgqXFac9r3=bYK+_nYe4cuXiNFg-623s6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 16:27 ` Andrew Morton [this message]
2012-10-28 19:02 ` [PATCH v7 11/16] net,l2tp: " Sasha Levin
2012-10-29 13:04 ` Mathieu Desnoyers
2012-10-28 19:02 ` [PATCH v7 13/16] lockd: " Sasha Levin
[not found] ` <1351450948-15618-13-git-send-email-levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-29 13:23 ` Mathieu Desnoyers
2012-10-29 11:29 ` [PATCH v7 01/16] hashtable: introduce a small and naive hashtable Mathieu Desnoyers
2012-10-29 16:06 ` Sasha Levin
2012-10-29 16:14 ` Mathieu Desnoyers
2012-10-29 16:18 ` Tejun Heo
2012-10-29 16:22 ` Mathieu Desnoyers
2012-10-29 16:26 ` Sasha Levin
[not found] ` <CA+1xoqfBXM4sjvcZtUncnWAaUxA9_YBod3Hjx3ZO=K1oJO_j7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-29 16:29 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029092758.1ab87d79.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=ccaulfie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=ejt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ericvh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
--cc=levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lw-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=neilb-l3A5Bk7waGM@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=teigland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=venkat.x.venkatsubra-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).