From: Thomas Graf <tgraf@suug.ch>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
Michele Baldessari <michele@acksyn.org>,
linux-sctp@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sctp: support per-association stats via a new SCTP_GET_ASSOC_STATS call
Date: Tue, 30 Oct 2012 14:51:56 +0000 [thread overview]
Message-ID: <20121030145156.GN13450@casper.infradead.org> (raw)
In-Reply-To: <508FE34D.8010402@gmail.com>
On 10/30/12 at 10:25am, Vlad Yasevich wrote:
> Can you give me some reasons why you prefer 0?
>
> 0 seems a bit strange to me. if someone was to construct a
> histogram of values, they would start with some initial value, then
> see 0s if there is no change, a spike for large rto, and if the
> spike is corrected, it would drop to 0 indicating no change...
> Seems odd.
>
> I would rather see what the current observed max rto is for an
> application polling period. Then a histogram can be correctly
> constructed.
0 would indicate that the rto has not been recalculated since
the last read and the app can decideitself whether to ignore
that read, replace it with rto_min or use the last known good
rto_max value.
Obviously this would mean that the patch needs to be changed
so it updates the max observed rto after applying rto_min in
sctp_transport_update_rto().
I'm perfectly fine with using rto_min as well though, we just lose
a bit of information that may be helpful to some users.
next prev parent reply other threads:[~2012-10-30 14:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 13:42 [PATCH net-next] sctp: support per-association stats via a new SCTP_GET_ASSOC_STATS call Michele Baldessari
2012-10-26 14:37 ` Neil Horman
2012-10-26 19:16 ` Vlad Yasevich
2012-10-27 11:35 ` Michele Baldessari
2012-10-27 15:48 ` Vlad Yasevich
2012-10-27 15:50 ` Vlad Yasevich
2012-10-29 16:38 ` Neil Horman
2012-10-29 20:11 ` Vlad Yasevich
2012-10-29 22:19 ` Neil Horman
2012-10-29 8:41 ` Thomas Graf
2012-10-29 11:37 ` Neil Horman
2012-10-29 20:22 ` Vlad Yasevich
2012-10-30 11:15 ` Neil Horman
2012-10-30 14:21 ` Vlad Yasevich
2012-10-30 14:54 ` Thomas Graf
2012-10-30 12:52 ` Thomas Graf
2012-10-30 14:25 ` Vlad Yasevich
2012-10-30 14:51 ` Thomas Graf [this message]
2012-10-26 20:00 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030145156.GN13450@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=michele@acksyn.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).